Cozary / Issue-Tracker

Issue Tracker of all of my mods.
0 stars 0 forks source link

ColoredWater: Fluid translations to be more compatible #37

Closed cech12 closed 1 year ago

cech12 commented 1 year ago

Mod: ColoredWater Version: 1.19.2-1.3.3 Bug explanation:

Hey, I am the mod developer of BucketLib and Ceramic Bucket.

Your mod does not contain translations for the fluids. To be more compatible with other mods, I would recommend to add such translations. :)

Bug image: grafik

Cozary commented 1 year ago

I didn't know "fluid_type" existed. I'll try to add it to the lang as soon as possible.

Cozary commented 1 year ago

I have uploaded an update to curseforge. Let me know if everything is ok.

cech12 commented 1 year ago

Thanks for your fast answer and work! :)

As far as I can see, you added language keys which are named for example "fluid_type.coloredwater.magentawater_fluid", but the language key which is returned by your fluid types is "fluid_type.coloredwater.magentafluid" (at the end "_water" is missing)

The method I use to get the language keys is fluid.getFluidType().getDescription(). https://github.com/cech12/BucketLib/blob/1.19/src/main/java/cech12/bucketlib/api/item/UniversalBucketItem.java#L89

Maybe you can change your fluid types to return the fluid language key or you change the language keys. :)

Cozary commented 1 year ago

I'll change the lang and that's it. I'll take a little while to do it.

Cozary commented 1 year ago

I have uploaded an update to Curseforge. (should be available soon).

I think that this time I have put the "language keys" correctly. Let me know if all goes well. ^^

cech12 commented 1 year ago

Now it is looking good! :) Thanks for your time! :)