search

CozySynthesizer / cozy

The collection synthesizer
https://cozy.uwplse.org
Apache License 2.0
209 stars 18 forks source link

Code review comments #43

Closed mernst closed 6 years ago

mernst commented 6 years ago

This is built on top of https://github.com/CozySynthesizer/cozy/pull/42 and so it should be examined after that is merged.

This should not be merged as is -- rather, the pull request exists to show the diffs (the added comments). Those should be edited before this is merged.

Calvin-L commented 6 years ago

@mernst I believe I have addressed all of your suggestions. Take another quick look, and then I will merge these improvements.

mernst commented 6 years ago

Looks good. Thanks for all the improvements, which make the code much easier to understand. My only comment is that No is a bit of a funny name. I will look more closely on my next pass. Thanks! Feel free to merge.