search

CpanelInc / backup-transport-dropbox

cPanel Custom Backup Transport for Dropbox
Apache License 2.0
15 stars 7 forks source link

uploads that reach transport timeout fail silently #16

Open cPWilliamL opened 5 years ago

cPWilliamL commented 5 years ago

When an upload reaches the transport timeout, the upload reports successful. Does the cpanel transporter send SIGTERM or SIGKILL?

cPWilliamL commented 5 years ago

There are two issues with the Custom Backup Transport itself, regardless of the script being used:

CPANEL-26245: Upload reports success if transport timeout is reached CPANEL-26328: Transport timeout is reached regardless of script output

The former case causes the system to falsely report that backups were uploaded successfully when it simply hit a timeout and the later causes the timeout to be reached prematurely.

It will be difficult to work around these issues without rewriting the Custom Backup Transport module, which it doesn't appear we have a method to override other than completely overwriting it and excluding it from updates.

cPWilliamL commented 5 years ago

CPANEL-26328 has been corrected in cPanel 80 and the fix is also targeted for cPanel 78, but not yet applied. The fix for CPANEL-26328 should correct CPANEL-26245 as well. Leaving open for further, testing.

@bryantmjb2, could you test with the newest version of this script(1.06, in master and development branches) and cPanel 80?