search

CptPotato / helix-themes

A few themes for the helix editor
MIT License
129 stars 14 forks source link

Make hints the same colour as comments. #11

Open jbtrystram opened 2 months ago

jbtrystram commented 2 months ago

Since https://github.com/helix-editor/helix/pull/5934 landed in 23.05 helix supports hints from the LSP.

This PR change the hints colors to be the same as comments because otherwise they show the same colour as code which is confusing.

I am far from a UX expert so feel free to suggest something better ! :)

Edit : after finding this post I landed on the following for ever-forest-medium-light :

"ui.virtual.inlay-hint" = {fg = "grey2", bg = "bg1", modifiers = ["italic"]}

image

CptPotato commented 1 month ago

Thanks for the contribution!

I think the comment color is a good choice here, signifying that it's not code and blending it a bit into the background. I'll try out the PR soon, but likely merge it as-is. The file mode change of the build script looks fine, too (I developed the themes on Windows which has no concept of an executable flag).

You may have noticed that this repo has become mostly stale, as I didn't have the time to consistently keep up with changes in helix and patch the themes accordingly. I'm fine PRs like this, but I don't know when/if I get back to it and rework the themes to cover all of helix' new features.

jbtrystram commented 1 month ago

You may have noticed that this repo has become mostly stale, as I didn't have the time to consistently keep up with changes in helix and patch the themes accordingly.

To be honest the theme looks good as is for me ! I just enabled hints, got confused and it was a quick fix :)

That's one of the reasons open source is nice, others can continue what you started