search

CptPotato / helix-themes

A few themes for the helix editor
MIT License
135 stars 15 forks source link

Cursorline defaults to background #2

Closed epbuennig closed 2 years ago

epbuennig commented 2 years ago

With the release of helix 22.08 come ui.cursorline.{primary,secondary} as keys for themes, recently most of the new keys were added, but not those.

Currently, the cursor line doesn't show up at all, if enabled, as it defaults to the background color.

I propose adding the following to at least schemes/gruvbox, but possibly all schemes:

"ui.cursorline.primary" = { bg = "bg1" }
"ui.cursorline.secondary" = { bg = "bg1" }

I also tried it with bg3, which drowned out the whitespace characters and felt a bit on the nose for a passive thing like that. Example using bg1 in gruvbox_original_dark_hard: image

CptPotato commented 2 years ago

Thanks for reporting, the color you suggested looks good to me 👍

I'll add the missing theme keys in a few days