search

Cr4xy / noita-seed-tool

https://cr4xy.dev/noita/index.html
MIT License
28 stars 5 forks source link

[suggestion] UI update with Perk Lottery re-rolls. #8

Open Meeeger opened 2 years ago

Meeeger commented 2 years ago

Not really an issue, but the UI would be a lot smoother if Perk Lottery re-rolls were more functional. Say you click on a perk and the other two stay. When you re-roll, the next two in line should replace the two there instead of updating all three. This also means calculating what you will receive on another re-roll in another Holy Mountain is difficult, as the re-roll order will be offset by one on the Seed Tool. I'm not the most experienced in JS, but it shouldn't be the hardest thing to implement into the code and UI. On another note, great work on making this tool for Noita community, its one of the best tools I've seen. Would be amazing to use it locally with the HTML file, but the code has requests that cannot be fulfilled locally.

Cr4xy commented 2 years ago

This is a nice idea. Thanks for the suggestion!

I think that this can be done, hopefully without breaking too many things :) - I'll just leave this open for now.

On the topic of running it locally, I would recommend taking a look at https://github.com/CoolElectronics/noita-seed-tool-electron/releases/tag/1.1

stefnotch commented 1 year ago

@Cr4xy If I ever want to take a stab at this, can I also upgrade the code to use Vue 3+Typescript while I'm at it? Or is that out of scope/going overboard?

Cr4xy commented 1 year ago

No, you can go ahead and do anything you want! :) It is probably a lot of work to get all this into typescript, but you can try if you want. 👍

Note: There is https://github.com/TwoAbove/noita-tools which already uses Typescript, I guess it is probably less effort to contribute over there if you just wanna add new features in Typescript.

stefnotch commented 1 year ago

Oh lovely, thank you for pointing me towards that other tool!