search

Crabar / ember-social-share

Social share buttons for EmberJS app that works without meta tags
MIT License
13 stars 10 forks source link

Update allowed attributes for Facebook shares #12

Closed renaekathleen closed 6 years ago

Crabar commented 6 years ago

Thanks for contribution! Could you also update a demo according to these changes?

renaekathleen commented 6 years ago

@Crabar I dd update the dummy app in /tests as part of the original PR. I'm not sure how to do a PR against your github.io demo, sorry.

renaekathleen commented 6 years ago

@Crabar would you be willing to version the addon in the package.json to account for this change, or would you prefer an additional PR?

Crabar commented 6 years ago

I will create and deploy version at this week. Unfortunately, now I just can't find a time to do this.