search

CrabeDeFrance / rtshark

Rust interface to tshark application
Other
32 stars 9 forks source link

Add `RTSharkBuilderReady::keylog_file` API #8

Closed vvv closed 1 year ago

vvv commented 1 year ago

Allow specifying the key log file that enables decryption of TLS traffic.

BlurMedia commented 1 year ago

Any update on this? Seems like a crucial piece of the api!

CrabeDeFrance commented 1 year ago

Hello ! Yes I saw this and I agree, this API looks very important. But to keep an acceptable level of quality for this crate, I think we should have at least one unit test per option. So when unit test is missing, it takes me some time to do it.

vvv commented 1 year ago

Thanks, @CrabeDeFrance!

But to keep an acceptable level of quality for this crate, I think we should have at least one unit test per option.

Yes, this is sensible. I'll try to do better next time.

CrabeDeFrance commented 1 year ago

It's ok, many thanks for the patch ! I was just explaining why there may be some delay.