Header, footer, nav.menu design

CraftAcademy / feb17-slow-food-sinatra

MIT License

0 stars 7 forks source link

Header, footer, nav.menu design #30

Closed Scharrre97 closed 7 years ago

Scharrre97 commented 7 years ago

Changes proposed in this pull request: adding index.erb adding menu adding cucumber test

What I have learned working on this feature: that Sinatra liks its files in certain places. like it whats images in lib/public and thats important to write the test in the right order

Screenshots:

Ready for review!

@AmberWilkie

AmberWilkie commented 7 years ago

You guys also need to fill out the description for this PR.

AmberWilkie commented 7 years ago

Ok very good. One last thing - screenshots. Any time you make visual updates to the page, you should take a screenshot and include it in the description. On a mac, you can do cmd-shift-4 to save a screenshot. Then just drag and drop it into the description (while it is in edit mode).

AmberWilkie commented 7 years ago

Also the title of this PR needs some work. What feature is being implemented here? Typically the title of the PR is the same as the card in Waffle.

tochman commented 7 years ago

Yes, please include screenshots of the browser. In OSX you SHIFT, CMD, 4 (at the same time) and then select the part of the screen you want to save. That image is saved on your Desktop. You include it in the description by simply dragging it to the edit area.

casperjureskog commented 7 years ago

yes now ints there in github :-)

AmberWilkie commented 7 years ago

.DS_Store is still part of this PR.

AmberWilkie commented 7 years ago

Add .DS_Store to your .gitignore file.

You also need to resolve the merge conflicts on this PR.