please specify an api version for plugins requesting it. - Githubissues

CraftCanvasMC / Canvas

Empowering the impossible within Minecraft

https://canvasmc.io

55 stars 7 forks source link

please specify an api version for plugins requesting it. #4

Closed pro9code closed 9 months ago

pro9code commented 9 months ago

Spark link

?

Expected behavior

not api version unsupported on slimefun 4 and coreprotect

Observed/Actual behavior

coreprotect dosn't work - please help!

Steps/models to reproduce

install coreprotect

Canvas version

latest-release [20:21:55 WARN] [Minecraft]: Unable to match version to pattern! Report to Canvas! [20:21:55 WARN] [Minecraft]: Pattern: ^([0-9.])-.R [20:21:55 WARN] [Minecraft]: Version: Unknown-Version

Agreements

[X] I am running the latest version of Canvas available from https://canvasmc-project.github.io/downloads/index.html.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[ ] I ticked all the boxes without actually reading them
[X] My version of Minecraft is supported by Canvas.

Other

No response

pro9code commented 9 months ago

also this ex.pdf

pro9code commented 9 months ago

and this https://www.spigotmc.org/resources/1-9-1-20-fork-custom-recipes-and-crafting-craftenhance.111998/

Dueris commented 9 months ago

So slimefun and coreprotect don't work due to the Canvas api version breaking?

Dueris commented 9 months ago

Just double checking before I work on fixing this

Dueris commented 9 months ago

Damn I gotta update the issue template to the right download page lol

pro9code commented 9 months ago

Correct.

On Tue, Nov 28, 2023 at 10:58 AM Dueris @.***> wrote:

Just double checking before I work on fixing this

— Reply to this email directly, view it on GitHub https://github.com/CraftCanvasMC/Canvas/issues/4#issuecomment-1830148435, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6A27QGRAJWFAZ3L2JMNPZ3YGYCZ3AVCNFSM6AAAAAA7447FVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQGE2DQNBTGU . You are receiving this because you authored the thread.Message ID: @.***>

Dueris commented 9 months ago

K. Should be an easy fix, will work on it in abt 20 minutes

Dueris commented 9 months ago

(Ignore this message I'm testing to see if my webhook fix for the discord server worked) Edit: it didn't lol

Dueris commented 9 months ago

Test again(final test before I just use --skip commits)

Edit: it worked

Dueris commented 9 months ago

Fixed. Merging with rebrand patch rn.

The issue was with me not changing the META-INF resource for getting the api version to the Canvas path. It's been resolved now and a build will be avalible shortly

Dueris commented 9 months ago

Pushing to downloads momentarily

pro9code commented 9 months ago

Thanks. This really helps a lot in testing plugins for my server.

On Tue, Nov 28, 2023, 12:18 PM Dueris @.***> wrote:

Closed #4 https://github.com/CraftCanvasMC/Canvas/issues/4 as completed.

— Reply to this email directly, view it on GitHub https://github.com/CraftCanvasMC/Canvas/issues/4#event-11086546667, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6A27QC6GRTPF2NHBEJ4CNTYGYMEVAVCNFSM6AAAAAA7447FVOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGA4DMNJUGY3DMNY . You are receiving this because you authored the thread.Message ID: @.***>