Support for comparing specific attributes in 'verify_embed'

CraftSpider / dpytest

A package that assists in writing tests for discord.py

MIT License

103 stars 24 forks source link

Support for comparing specific attributes in 'verify_embed' #36

Closed Sillocan closed 3 years ago

Sillocan commented 4 years ago

I noticed that verify_embed did not compare certain embed fields. I had made local modifications in-order to assert field attributes and other fields. These let the user decide if they want to compare attributes such as fields or just do a full comparison.

Adds boolean for full comparison of embeds.
Adds optional list for individual attributes to compare in embeds.
Outputs the differing embeds in the assert message when equals is 'True'. (Does a diff if the proper libs are installed. I can easily git rid of this if people don't want to start doing things like this.)

Still need to add new test cases for these attributes.

bravosierra99 commented 3 years ago

I really really really hate github notifications. Hey, I haven't been checking this project until today. I'll take a look and merge it in. I'm also going to setup some webhooks so I don't miss this stuff.

bravosierra99 commented 3 years ago

oh haha, just noticed this is going to @CraftSpider and not my fork. Anyways, it looks fairly good to me, though some bugs may shake out with use.

bravosierra99 commented 3 years ago

@Sillocan I would love to use this feature, any chance you would create a pull request to my fork?

Sillocan commented 3 years ago

Sure. I can do that later tonight!

On Sat, Jan 2, 2021, 1:51 PM Benjamin Smith notifications@github.com wrote:

@Sillocan https://github.com/Sillocan I would love to use this feature, any chance you would create a pull request to my fork?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CraftSpider/dpytest/pull/36#issuecomment-753515022, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMNNWPPWDDLZLLK427BAU3SX5TMDANCNFSM4R3EZBTQ .

Sergeileduc commented 3 years ago

The issue is still there (we don't compare all attributes or fields...).

But the branches have now diverted, there's conflicts, etc...

I don't know if I close the PR, or leave it open for changes...

Sergeileduc commented 3 years ago

Too many changes since the PR. We can adress this issue, but right now, the PR is too obsolete. Closing.