CraftoryStudios / Craftory-Tech

Craftory sets out to extend and push the boundaries of vanilla Minecraft, offering features only thought possible before with Modded Minecraft.
https://craftory.studio/craftory-tech/
GNU General Public License v3.0
16 stars 9 forks source link

[BUG] Resource pack mistaking vanilla mushroom stem blocks as craftory blocks #153

Closed cloakfox closed 2 years ago

cloakfox commented 3 years ago

I have been watching this project for a while now and wanted to try it out on a new setup, after installing Craftory 0.6.0 & latest resourcepack (with transport pipes) I noticed a lot of the vanilla blocks in our spawn are now changed/displayed as craftory blocks. 2021-10-13_14 25 41

cloakfox commented 3 years ago

Also noticed that textures in the distance have more noise after installing the resource pack https://imgur.com/a/oHfu2rG

Mostly notice-able when looking at roads in the distance

cloakfox commented 3 years ago

F

brettsaunders21 commented 2 years ago

Also noticed that textures in the distance have more noise after installing the resource pack imgur.com/a/oHfu2rG

Mostly notice-able when looking at roads in the distance

I don't see how this can be us, all we do is add a resource pack that changes a few textures. It has no effect on Minecraft rendering or other texutres

brettsaunders21 commented 2 years ago

Unfortunately the other issue is because we use mushroom stem block textures, we should only be using ones that Minecraft doesn't, but it seems we overrode a few others

Here is the list of block states we use https://github.com/CraftoryStudios/Craftory-Tech/blob/master/resourcepacks/original/assets/minecraft/blockstates/mushroom_stem.json

If you use world edit to set all mushroom stems to one of the unused block states this will fix it

cloakfox commented 2 years ago

Unfortunately the other issue is because we use mushroom stem block textures, we should only be using ones that Minecraft doesn't, but it seems we overrode a few others

Here is the list of block states we use https://github.com/CraftoryStudios/Craftory-Tech/blob/master/resourcepacks/original/assets/minecraft/blockstates/mushroom_stem.json

If you use world edit to set all mushroom stems to one of the unused block states this will fix it

Ah alright, i've fixed this issue now, thanks! as for the resourcepack showing way more noise in the rendered image, that one doesnt make sense to me, it can easily be reproduced so not sure how nobody else has noticed it before.

cloakfox commented 2 years ago

Unfortunately the other issue is because we use mushroom stem block textures, we should only be using ones that Minecraft doesn't, but it seems we overrode a few others Here is the list of block states we use https://github.com/CraftoryStudios/Craftory-Tech/blob/master/resourcepacks/original/assets/minecraft/blockstates/mushroom_stem.json If you use world edit to set all mushroom stems to one of the unused block states this will fix it

Ah alright, i've fixed this issue now, thanks! as for the resourcepack showing way more noise in the rendered image, that one doesnt make sense to me, it can easily be reproduced so not sure how nobody else has noticed it before.

I noticed the noise is only applied when the player is not moving, when flying around or moving it's not applied.

brettsaunders21 commented 2 years ago

We will look further into ensure we only use unused block stated in the future.

Regarding the other issue, we just add textures to a resource pack. It's very unlikely we cause this issue, I actually don't know how we could if we wanted to.

No one is able to replicate it so it's likely to be an issue on your end, as it's rendering it would be a client side issue.