search

CraftoryStudios / Craftory-Tech

Craftory sets out to extend and push the boundaries of vanilla Minecraft, offering features only thought possible before with Modded Minecraft.
https://craftory.studio/craftory-tech/
GNU General Public License v3.0
15 stars 9 forks source link

[BUG] Weird Visual Effect with Resource Pack on Stone Bricks #191

Open iCaitlyn opened 2 years ago

iCaitlyn commented 2 years ago

Description The resource pack used with Craftory creates weird visual effects with Stone Bricks which doesn't occur normally or with other resource packs.

Reproduction Steps Tell us the exact steps to reproduce this issue, the more detailed the easier we can reproduce it:

  1. Look at a large expansive flat surface of stone bricks
  2. Enable the Craftory Tech pack
  3. Look at a large expansive flat surface of stone bricks again

Expected Behavior The curved banding of the lines shouldn't occur.

Screenshots / Video Without Craftory Tech resource pack: Before

With Craftory Tech resource pack: After

Server Log N.A.

Server Error Tracking ID N.A.

Version Infomation

Additional context In the screenshots, a texture pack may have been used, but even without it, the issues remain.

iCaitlyn commented 2 years ago

Seems like this was noticed before in #153 too

However, this issue literally only occurs when we add the Craftory Tech pack, and even with absolutely no other resource packs, it still occurs.

The other admin of our server who uses just vanilla minecraft (eg. no Fabric modloader and mods), also notices the issue as soon as the craftory resource pack is applied.

iCaitlyn commented 2 years ago

Testing of the Resource Pack

Preliminary testing

The components of the Craftory resource pack has shown that as soon as "assets/extra" is included, the noise issue appears.

Edit 2

Issue seems to be located within "assets/extra/textures" after a bit more testing

Edit 3

Now narrowed down to "assets/extra/textures/items"

Edit 4

"arrow/", "battery/", "book/", "output/", "tank/", "turretConfig/", and "invisible.png" are fine. Something in "assets/extra/textures/items/light" is causing the issue.

Edit 5

"assets/extra/textures/items/light/light_off.png" causes the issue. "light_on.png" and "light_on.png.mcmeta" do not.

Conclusion

Somehow or someway, the file "assets/extra/textures/items/light/light_off.png" is causing the noise issue, either in how it is applied or interpreted by the game.

MMJ744 commented 2 years ago

@iCaitlyn Thanks for the thorough investigation. I'm not sure how the image could cause this issue but we will try to find a solution.