search

CraigT543 / EasyBlue

Modifications for Easy!Appointments
21 stars 23 forks source link

Selecting All Providers does not return all available slots #30

Open EdB987 opened 6 years ago

EdB987 commented 6 years ago

In the appointment selector, choosing - Any Provider - does not return all available slots for a given service. Choosing any discreet provider does return the available slots.

Shouldn't the - Any Provider - return the composite view of all available providers of a given service? I have tested this behavior on base EA and with Easy Blue 1.2.1 with same results.

Additionally, the logs show

"ERROR - 2018-02-23 10:41:40 --> Severity: error --> Exception: $provider_id argument is not a valid numeric value: any-provider /path-to-app/application/models/Providers_model.php 319

Any help is appreciated

CraigT543 commented 6 years ago

I will have to take a look there. I think I limited it to one provider given that I am a one man show. I do not have much time to dig into it. But I am pretty sure that the issue would be in the /application/views/appointments/book.php file at the code for the combo box. I am pretty sure that is where I made the modifications that affect this. But I cannot get to it any time soon unfortunately.

EdB987 commented 6 years ago

in further testing - it seems that issue #298 and #247 of EA get at the issue of ANY PROVIDER. In a lot of further testing with EasyBlue (thank YOU and Alex for very cool projects), I've narrowed the problem down to this:

All of this works great - except the search logic (in Appointments.php) seems to break down when the window of available time is less than 2X the service length - ie: the appointment wizard doesn't find any open attendants except for the first one when the open space is <= the available time in the calendar (not blocked by non working, break or not available.)

When the time available is exactly the same as the required time for the service, the wizard finds the first attendant, but not the rest.

I'm new to the frame work so am just learning. In all the tool is perfect for my needs and I'll keep plugging until I determine why the wizard is skipping over clearly available slots.

Thanks for any assistance in tracking this down!