Crain-32 / Multiworld_Client

MIT License
1 stars 4 forks source link

Client Deletes Incoming Items #4

Open Crain-32 opened 2 years ago

Crain-32 commented 2 years ago

Issue

The current implementation of check_valid_state() -> bool: in windWakerInterface.py doesn't account for certain edge cases. Namely time between saving, stage transitions, and potentially others situations.

Desired Resolution

check_valid_state() -> bool: should return False if giving the item would delete it, meaning the above mentioned situations need to be scanned and prevented.

Potential Tips

You might find it useful to use the GUI version of Dolphin-Memory Engine, in coordination with Frame-Advancing Dolphin, in order to pinpoint invalid frames for giving items, and finding information on the memory that might help track for valid state.