There is now a clear seperation between game handling commands and dolphin commands. Currently gameHandler will always create a new dolphin instance, but this can be changed due to the usage of an abstract class.
Client/dolphinGameHandler.py handles the direct interface between the client and dolphin. We expect all dolphin related code to sit within this file. Uses the abstract class.
Client/gameHandler.py handles the logic between the client and the console. Console being both dolphin and the Wii. We should not expect and dolphin specific code here.
Things to look into
The only thing I haven't removed is the usage of Dolphin.windWakerResources in gameHandler as it is used to print messages.
read_chest_items and clear_chest_items could probably be more generic and switched to something else? It may not need to be a abstract class method.
There is now a clear seperation between game handling commands and dolphin commands. Currently
gameHandler
will always create a newdolphin
instance, but this can be changed due to the usage of an abstract class.Client/dolphinGameHandler.py
handles the direct interface between the client and dolphin. We expect all dolphin related code to sit within this file. Uses the abstract class.Client/gameHandler.py
handles the logic between the client and the console. Console being both dolphin and the Wii. We should not expect and dolphin specific code here.Things to look into
Dolphin.windWakerResources
ingameHandler
as it is used to print messages.read_chest_items
andclear_chest_items
could probably be more generic and switched to something else? It may not need to be a abstract class method.