Cran3
commented
6 years ago Hey, Farish. Thank you for the thorough feedback, I appreciate it. I'll take a look at Flexbox Froggy and make sure I don't repeat myself next time in code. 👍
Open farishkash opened 6 years ago
Cran3
commented
6 years ago Hey, Farish. Thank you for the thorough feedback, I appreciate it. I'll take a look at Flexbox Froggy and make sure I don't repeat myself next time in code. 👍
Overall met expectations.
You did your own style and setup for this page which is great. I always appreciate when learners experiment.
Some of your issues are more with regards to fundamental concepts such as using ID instead of Class, the others are structural. These are easy to fix.
In this first project, I look at 3 items.
Div usage: Good on this.
HTML organization with the use of IDs/Class. Just need classes to be used instead of IDs when wishing to apply the same style to multiple elements.
CSS Repetition and Structure. The structure is good. Whenever you are repeating yourself, you should always look at options that CSS offers to reduce this.
Try to follow the examples given your future projects.
To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.