Crane1195 / DIYB0XX

GNU General Public License v3.0
91 stars 21 forks source link

Wrong stick coordinates since Slippi 2.5.0 #4

Closed CollaboratingElephant closed 2 years ago

CollaboratingElephant commented 2 years ago

Device: Leonardo R3 Arduino ATMega32U4 Pro Micro Host: USB-B to USB-A, DIYGCC_USB Game: Melee, Slippi 2.5.0 Buttons pressed while plugging in: None Actions: Pressing modX and various control stick directions

Expected behaviour: Modx+down producing the Y value of -0,28750, Modx+left producing the X value of -0,66250 Modx+left+down producing the X value of -0,73750, and Y value of -0,28750

Actual behaviour: Modx+down produces the Y value of -0,27500 Modx+left produces the X value of -0,65000 Modx+left+down produces the X value of -0,72500, and Y value of -0,27500.

All of this started happening only when Slippi updated to 2.5.0, and Arte suggested it might be because of this pull:

https://github.com/project-slippi/Ishiiruka/pull/356

CollaboratingElephant commented 2 years ago

The Slippi team reverted the changes that lead to the issue. Problem solved.