Crash-m / thelastripper

Automatically exported from code.google.com/p/thelastripper
0 stars 0 forks source link

mp3 not written if there is a quotation mark in the filename #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Description of the issue: mp3 not written if there is a quotation mark in
the filename

What steps will reproduce the problem?
1. Lenny Bruce's Live at the Curran Theater contains a track with the
following 'filename'

In Which The Artist Discusses "The Lie", His Courtroom Fantasy, George
Shearing And Guide Dogs For The Blind, Tropic Of Cancer, Cops And Bad
Toilet Training, And Describes The Philadelphia Hotel Room Raid. (Live)

2. Add to playlist
3. Wait for it to stream

What is the expected output?

An mp3 file, possibly with an underscore in the filename replacing the
quotation mark

GENERAL INFORMATION ABOUT YOUR SYSTEM:

TheLastRipper version? v1.31
Mono/.Net runtime version?
Operating system and version? winxp pro

Original issue reported on code.google.com by topmor...@gmail.com on 12 Mar 2008 at 10:04

GoogleCodeExporter commented 9 years ago
Couldn't figure out how to search for tracks with quotation marks in them. 
Found one
and it was ripped successfully, so it might be filename length?

Original comment by topmor...@gmail.com on 12 Mar 2008 at 11:51

GoogleCodeExporter commented 9 years ago
It would be good if the file and folder could go through a robust validation:

Suggestion for some steps that might do the job:
* check if the name actually works before doing anything if it doesn't then 
subject 
it to a screening procedure and then retry: 

Screening:
* hold each char against a whitelist of accepted chars. If it isn't in there 
then 
replace with eg an underscore. More advanced translation of chars can be added 
later.
* If the filename is too long then first remove all spaces and change case to 
TitleCase. If that is not short enough then simply truncate at limit.

Original comment by grins...@gmail.com on 5 Jun 2008 at 12:22

GoogleCodeExporter commented 9 years ago
fixed in my opinion - please recreate issue if any filename problems occur

Original comment by andreas....@gmail.com on 18 Feb 2009 at 6:04