Crash-m / thelastripper

Automatically exported from code.google.com/p/thelastripper
0 stars 0 forks source link

Skip existing music option fails to skip existing music #131

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Description
After checking 'skip existing music' I note that the application does not
skip existing music that resides in my music folder.  I have a quarantine
directory specified as c:\temp

Steps:
1. set music directory value to one which contains existing music ripped by
the application
2. set quarantine directory to 'c:\temp' or equivalent
3. under 'advanced' tab in settings menu, turn on 'skip existing music' option
4. login and begin ripping from a playlist which contains songs previously
ripped and saved to the music directory folder
5. note that existing songs are not skipped by the application, but saved
in the quarantine directory

Expected:
The application should move to the next track in the stream.  Either by
verifying existing tracks using their filenames', or comparing a hash based
on one or more properties for each track

System info:
v1.3.1
.Net 2.1.21022
Windows XP Pro 2002 with SP3

Original issue reported on code.google.com by colic...@gmail.com on 18 Nov 2008 at 9:34

GoogleCodeExporter commented 8 years ago
To clarify, this appears to only occur when a value is given for the quarantine 
directory

Original comment by colic...@gmail.com on 20 Nov 2008 at 5:16

GoogleCodeExporter commented 8 years ago
IMO it shouldn't skip tracks at all, maybe avoid saving them... But not skip 
them,
since skipping too many times causes last.fm to disconnect.

Original comment by jopsen@gmail.com on 20 Nov 2008 at 9:14

GoogleCodeExporter commented 8 years ago
I take "skip" in the context of this option to mean "avoid saving tracks that 
already
exist".  The issue is that the logic behind this option does not work to "avoid
saving existing music".

Original comment by colic...@gmail.com on 20 Nov 2008 at 9:41

GoogleCodeExporter commented 8 years ago
fixed in beta5. The issue with last.fm disconnects because of too much skipping
should be solved with a delay between requests. Will be solved in b6!

Original comment by andreas....@gmail.com on 4 Feb 2009 at 10:40