International characters

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Wait until there's something with international chars played. ;)

What is the expected output? What do you see instead?
Those chars are skipped in both IDv3 and files. For example "Sigur Rós"
becomes "Sigur Rs".

What version of the product are you using? On what operating system?
1.0.2 Linux port

Original issue reported on code.google.com by virap...@gmail.com on 24 Mar 2007 at 2:54

[GoogleCodeExporter]

well, first things first, thelastripper only has ID3v1 support not v3...
As far as I'm aware there many (international) characters that's not supported 
as
filenames and in ID3v1...

Currently I remove unsupported characters with very simple method called
RemoveIllegalChars in
http://thelastripper.googlecode.com/svn/trunk/LinuxBranch/TheLastRipper/LibLastR
ip/LastManager/LastManager.cs
Notify me, if I'm removing too many characters... (I know the current solution 
is a
little ugly, but it works).

For the moment being, we don't consider this a serious issue. Since it probably 
wold
require implementation of ID3v3, which would take some time.

I know that Mono has some kind of method for removal of illegal characters in 
path
names... Perhaps that would do something for the filenames... 

Original comment by jopsen@gmail.com on 24 Mar 2007 at 3:09

• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

I meant ID3 tag in general, not ID3v3 - my bad :)
But ripper needs ID3v2 - for this issue and for
http://code.google.com/p/thelastripper/issues/detail?id=5
It just looses too much information that last.fm can give.

Anyway - does ripper need to remove any chars from file names? Linux can deal 
with
names like łóążźćęðöækĸµ without problems - so why should program 
interfere? Maybe
just give an option - whether user wants to strip special chars from file name, 
or not?

Original comment by virap...@gmail.com on 24 Mar 2007 at 7:34

[GoogleCodeExporter]

Well, it's needed to strip som chars from files names... slash for an 
instance...
But I don't have a complete list of illegal characters, so I just went wit does 
I
knew where safe :)
Later I discovered that mono might have a method for it, don't remember the 
exact
name. But I've also got to make sure that it's also available on MS .Net... 

Original comment by jopsen@gmail.com on 24 Mar 2007 at 7:46

[GoogleCodeExporter]

try to convert the chars given from last.fm in UTF-8 to system.enciding.Ascii. 
you'll
find serveral routines on the internet. I had to deal with the same problem, 
but I
cannot give you some code snippet atm because my graphics card is broken down 
at my
porgramming computer....

Original comment by t.bu...@gmail.com on 4 Jul 2007 at 1:36

[GoogleCodeExporter]

Invalid chars for filename and path can be found in
System.IO.Path.GetInvalidPathChars() and .GetInvalidFileNameChars().

This issue have been fixed as of revision: 176, though QA is still needed, but 
it
compiles :)

Original comment by jopsen@gmail.com on 30 Jul 2007 at 10:55

• Changed state: Fixed