search

CrashOverride85 / zc95

4 channel EStim box inspired by the mk312bt, with Lua scripting support
GNU General Public License v3.0
46 stars 12 forks source link

Consider adding a serial baud rate menu config option #48

Closed jlatex closed 1 year ago

jlatex commented 1 year ago

By default the serial port runs at PICO_DEFAULT_UART_BAUD_RATE (115200). My longish serial cable and usb serial adapter on aux couldn't keep up with that and so I edited CDebugOutput.cpp to drop the baud rate to 38400. Ideally this would be a menu config option.

CrashOverride85 commented 1 year ago

Depending on what you're using serial for, this might be slightly harder than it seems. For the new remote control & Lua upload over serial stuff, having it changeable via the menus should be ok.

But for debug/diagnostic output, the main issue I can see is that on startup there's a few things it does before reading the EEPROM, so it's going to be outputting at the default baud rate until that happens. Switching baud rates during startup doesn't seem ideal really. Although having thought about it, it's similar to how the debug destination can change after reading the EEPROM, so maybe changing the baud rate at that point too is fine.

jlatex commented 1 year ago

That's fair; I don't mind keeping mine at 57600 or something by just compiling it myself. And if anyone else has issues with the speed perhaps consider using that as the default.

jlatex commented 2 weeks ago

anyone finding this old closed issue later - the problem was my ftdi serial board. replacing it with another one and no other changes and i got 115200 serial with no problems.