search

CraterCrash / godot-orchestrator

Orchestrator: Unleashing Creativity with Visual Scripting
https://www.cratercrash.com/orchestrator
Apache License 2.0
999 stars 55 forks source link

Closing Godot does not warn about pending changes to orchestrations #721

Open dschiller opened 3 months ago

dschiller commented 3 months ago

Describe the bug

When changing a EventGraph and quitting Godot there is no warning for unsaved data. Also there is no asterisk "somewhere" to mark the EventGraph as changed. When reopening the Project the changes done in the EventGraph are lost.

Expected behavior

Change any EventGraph should inform the user with an asterisk about unsaved data changes. Also Godot should not quit when EventGraph's are "dirty" (unsaved).

Actual behavior

Changing a EventGraph and quitting Godot does not warn nor save the changes.

How to Reproduce?

  1. Open a Project with a EventGraph
  2. Change the EventGraph
  3. Quit Godot
  4. Reopen the Project >> Changes are gone

Godot full version

4.3.rc3

Orchestrator version

2.1.rc4

Additional information

No response

Naros commented 3 months ago

The main issue is that there is no universal way to track Resource::is_edited since that isn't exposed to GDExtension. I have an open PR in the upstream Godot to add this, which I believe they delayed until Godot 4.4. :(

dschiller commented 3 months ago

Could you invalidate any other file / resource ? Maybe the one that the Orchestrator script is assigned to ?