CraterCrash / godot-orchestrator

Orchestrator: Unleashing Creativity with Visual Scripting
https://www.cratercrash.com/orchestrator
Apache License 2.0
981 stars 53 forks source link

Updating to version 2.1 causes Godot to fail to start #760

Closed jxaytl13 closed 1 month ago

jxaytl13 commented 2 months ago

Describe the bug

Godot4.3 version is updated from Orchestrator2.0 to Orchestrator2.1. After completion, you will be prompted to restart godot. godot will not start after restarting. Delete Orchestrator2.1 in the project file.

Expected behavior

No response

Actual behavior

Open godot4.3. Update the original Orchestrator2.0 to 2.1. Prompt to restart godot. Godot will not be able to start normally after restarting, causing a crash.

How to Reproduce?

No response

Godot full version

4.3

Orchestrator version

2.1

Additional information

No response

Naros commented 2 months ago

Hi @jxaytl13, please open a blank project in Godot, click Help > About Godot and at the top of the dialog, click the line that reads "Godot Engine..." and paste the text it puts on the clipboard here, please.

i.e.

v4.4.dev.custom_build [8691da0f2]
jxaytl13 commented 2 months ago

你好@jxaytl13,请在 Godot 中打开一个空白项目,单击,Help > About Godot然后在对话框顶部单击“Godot Engine...”行,然后将其放在剪贴板上的文本粘贴到这里。

IE IE浏览器

v4.4.dev.custom_build [8691da0f2]

hello: v4.3.stable.official [77dcf97d8]

Naros commented 2 months ago

Thanks @jxaytl13. Are you using a custom theme in the editor? What is your operating system? Also what version of Orchestrator did you update from specifically, was it 2.0.stable or something else?

jxaytl13 commented 2 months ago

谢谢@jxaytl13。您在编辑器中使用自定义主题吗?您的操作系统是什么?

No custom theme is used, Godot's default one is used. My operating system is wind 10 Orchestrator is updated from version 2.0 to 2.1 30 1 2

Naros commented 2 months ago

Hmm, and the crash happens even in an empty project where you update Orchestrator from 2.0 to 2.1?

jxaytl13 commented 2 months ago

嗯,即使在空项目中将 Orchestrator 从 2.0 更新到 2.1 也会发生崩溃吗?

yes

Naros commented 2 months ago

After you have updated to 2.1, can you open a cmd window and navigate to where your Godot executable is, and there will be a second executable there named something like Godot_v4.3.blah.blah.console.exe, can you run the console version and see if it outputs any meaningful details about the crash?

Naros commented 2 months ago

One final question, is this Godot one you installed from Steam from the official Godot website?

jxaytl13 commented 2 months ago

最后一个问题,这个 Godot 是你从 Steam 上的 Godot 官方网站安装的吗?

It's not from steam, it's downloaded from Godot official website.

jxaytl13 commented 2 months ago

Will Orchestrator's nodes be translated into Chinese in the future? Like UE's blueprint.

Naros commented 2 months ago

After you have updated to 2.1, can you open a cmd window and navigate to where your Godot executable is, and there will be a second executable there named something like Godot_v4.3.blah.blah.console.exe, can you run the console version and see if it outputs any meaningful details about the crash?

Can you perform this for me?

Will Orchestrator's nodes be translated into Chinese in the future? Like UE's blueprint.

Yes, though I cannot give a specific version when that will be added, but its something we want to add. We intend to do it similar to Godot with weblate & allow users to add translations that will get built into the plug-in automatically.

jxaytl13 commented 2 months ago

更新到 2.1 后,您可以打开一个cmd窗口并导航到您的 Godot 可执行文件所在的位置,并且那里会有第二个可执行文件,名称类似于Godot_v4.3.blah.blah.console.exe,您可以运行控制台版本并查看它是否输出有关崩溃的任何有意义的详细信息吗?

zz dfgh

Naros commented 2 months ago

What happens if you set Godot to use English rather than Chinese, does it work? I'm wondering if Godot is translating some node names we are specifically looking for and that you could be facing a dereference problem because we expect to get the node back.

Although I searched the code, and all the find_children calls are guarded with null pointer checks 🤔

jxaytl13 commented 2 months ago

如果您将 Godot 设置为使用英语而不是中文,会发生什么情况?它会起作用吗?我想知道 Godot 是否正在翻译我们专门寻找的一些节点名称,并且您可能会面临取消引用的问题,因为我们希望取回节点。

尽管我搜索了代码,并且所有find_children调用都受到空指针检查的保护🤔

我试试

Naros commented 2 months ago

Did that work?

Naros commented 2 months ago

I tried with Orchestrator 2.1.stable locally with zh_CN language and it works, so I'm not really sure why it crashes for you. We mostly develop on Windows 11 and Fedora here. I'm guessing that if you download the 2.1.stable release from GitHub here and install it manually you have the same problem?

jxaytl13 commented 2 months ago

I tried with Orchestrator 2.1.stable locally with zh_CN language and it works, so I'm not really sure why it crashes for you. We mostly develop on Windows 11 and Fedora here. I'm guessing that if you download the 2.1.stable release from GitHub here and install it manually you have the same problem?

Downloads from github crash all the same

jxaytl13 commented 2 months ago

Does it have anything to do with the choice I made when I created it? screenshot-20240818-111103

jxaytl13 commented 2 months ago

Does it have anything to do with the choice I made when I created it? screenshot-20240818-111103

Tried replacing it with something else, still the same.

Naros commented 2 months ago

No that render type doesn't matter, are you able to join our discord, so I can share a debug build with you? https://discord.gg/J3UWtzWSkT

I've started a thread at https://discord.com/channels/1049457206648655912/1274568067636133941/1274568067636133941 with a debug downloadable artifact that we can try.

jxaytl13 commented 2 months ago

No that render type doesn't matter, are you able to join our discord, so I can share a debug build with you? https://discord.gg/J3UWtzWSkT

I'll try again when the version on AssetLib is 2.1. dfdfdf

jxaytl13 commented 2 months ago

I have a question. I really like Orchestrator and would like to use it as my main tool in the future. However, I'm worried that since it's not official, it might be abandoned by its author later on. I'm hesitating between using GD (Godot's built-in scripting language) and Orchestrator.

Jompschz commented 2 months ago

Yes I've the same issue, my project doesn't start :0

Naros commented 2 months ago

What happens if you re-install the latest Microsoft C++ Redistributable?

Jompschz commented 2 months ago

What happens if you re-install the latest Microsoft C++ Redistributable?

yes this solve the problem. now works!!! :D

UPDATE: on a new project not works :0

Naros commented 2 months ago

UPDATE: on a new project not works :0

I would double check that in both projects you are using the same version of the addon. I did check the GitHub windows-latest runners and as of 2024/08/24 they are deployed with Microsoft Visual C++ Redistributable version 14.40.33810.

This information is available here on GitHub and is updated by GitHub periodically.

Naros commented 2 months ago

Hi @Jompschz is everything good?

Naros commented 1 month ago

Feel free to re-open if updating the Microsoft Visual C++ Redistributable doesn't help.