search

CraterCrash / godot-orchestrator

Orchestrator: Unleashing Creativity with Visual Scripting
https://www.cratercrash.com/orchestrator
Apache License 2.0
981 stars 53 forks source link

Application crash on launch after adding Orchestrator (Godot 4.3, Orchestrator 2.1) #778

Closed elmustardo closed 2 months ago

elmustardo commented 2 months ago

Describe the bug

Application crash on launch after adding Orchestrator (Godot 4.3, Orchestrator 2.1)

This occurs immediately after installing the addon and going through the save & restart process)

Note this is on a brand new, blank project.

Expected behavior

I'd expect the application to launch lol

Actual behavior

Godot splash opens, then quickly closes.

Following logs are from windows event viewer

Log Name:      Application
Source:        Application Error
Date:          8/23/2024 7:54:59 PM
Event ID:      1000
Task Category: Application Crashing Events
Level:         Error
Keywords:      
User:          ASUSDONNY\barba
Computer:      AsusDonny
Description:
Faulting application name: Godot_v4.3-stable_win64.exe, version: 4.3.0.0, time stamp: 0x66bd392d
Faulting module name: ~orchestrator.windows.64.release.dll, version: 0.0.0.0, time stamp: 0x66bdf875
Exception code: 0xc0000005
Fault offset: 0x00000000002c52aa
Faulting process id: 0x0x392C
Faulting application start time: 0x0x1DAF5C03CD0C6FE
Faulting application path: C:\Users\barba\OneDrive\Documents\Godot_v4.3-stable_win64.exe
Faulting module path: C:\Users\barba\OneDrive\Documents\new-game-project\addons\orchestrator\~orchestrator.windows.64.release.dll
Report Id: 51499045-7ced-46f2-a159-1918dbae81a1
Faulting package full name: 
Faulting package-relative application ID: 
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" Guid="{a0e9b465-b939-57d7-b27d-95d8e925ff57}" />
    <EventID>1000</EventID>
    <Version>0</Version>
    <Level>2</Level>
    <Task>100</Task>
    <Opcode>0</Opcode>
    <Keywords>0x8000000000000000</Keywords>
    <TimeCreated SystemTime="2024-08-24T00:54:59.0118723Z" />
    <EventRecordID>2771</EventRecordID>
    <Correlation />
    <Execution ProcessID="18528" ThreadID="18476" />
    <Channel>Application</Channel>
    <Computer>AsusDonny</Computer>
    <Security UserID="S-1-5-21-3479317282-2319502678-3977097404-1001" />
  </System>
  <EventData>
    <Data Name="AppName">Godot_v4.3-stable_win64.exe</Data>
    <Data Name="AppVersion">4.3.0.0</Data>
    <Data Name="AppTimeStamp">66bd392d</Data>
    <Data Name="ModuleName">~orchestrator.windows.64.release.dll</Data>
    <Data Name="ModuleVersion">0.0.0.0</Data>
    <Data Name="ModuleTimeStamp">66bdf875</Data>
    <Data Name="ExceptionCode">c0000005</Data>
    <Data Name="FaultingOffset">00000000002c52aa</Data>
    <Data Name="ProcessId">0x392c</Data>
    <Data Name="ProcessCreationTime">0x1daf5c03cd0c6fe</Data>
    <Data Name="AppPath">C:\Users\barba\OneDrive\Documents\Godot_v4.3-stable_win64.exe</Data>
    <Data Name="ModulePath">C:\Users\barba\OneDrive\Documents\new-game-project\addons\orchestrator\~orchestrator.windows.64.release.dll</Data>
    <Data Name="IntegratorReportId">51499045-7ced-46f2-a159-1918dbae81a1</Data>
    <Data Name="PackageFullName">
    </Data>
    <Data Name="PackageRelativeAppId">
    </Data>
  </EventData>
</Event>

How to Reproduce?

No response

Godot full version

4.3.Stable.Official

Orchestrator version

godot-orchestrator-v2.1-stable-plugin

Additional information

N/A

Naros commented 2 months ago

Do you have the latest 2015-2022 Microsoft C++ Redistributable installed @elmustardo ?

elmustardo commented 2 months ago

I just downloaded and installed the latest of both the x86 and x64 since I saw that note in the other thread. Crash still persists.

image

elmustardo commented 2 months ago

Windows crash report log

Version=1
EventType=APPCRASH
EventTime=133689344991797384
ReportType=2
Consent=1
UploadTime=133689344995291587
ReportStatus=268435456
ReportIdentifier=9798119b-7cef-470e-9540-aea8edc5b82a
IntegratorReportIdentifier=51499045-7ced-46f2-a159-1918dbae81a1
Wow64Host=34404
NsAppName=Godot_v4.3-stable_win64.exe
AppSessionGuid=0000392c-0001-0013-fec6-d03cc0f5da01
TargetAppId=W:00067a6e7b146d39bd5672123a455669526b00000904!000089985c4f2fa061ccdb1cf510218ab331d0079ba9!Godot_v4.3-stable_win64.exe
TargetAppVer=2024//08//14:23:09:33!7ec43dc!Godot_v4.3-stable_win64.exe
BootId=4294967295
TargetAsId=643
UserImpactVector=3158832
IsFatal=1
EtwNonCollectReason=1
Response.BucketId=30ea8931f77eb581e3698aa7d361f46d
Response.BucketTable=4
Response.LegacyBucketId=1398801612685833325
Response.type=4
Sig[0].Name=Application Name
Sig[0].Value=Godot_v4.3-stable_win64.exe
Sig[1].Name=Application Version
Sig[1].Value=4.3.0.0
Sig[2].Name=Application Timestamp
Sig[2].Value=66bd392d
Sig[3].Name=Fault Module Name
Sig[3].Value=~orchestrator.windows.64.release.dll
Sig[4].Name=Fault Module Version
Sig[4].Value=0.0.0.0
Sig[5].Name=Fault Module Timestamp
Sig[5].Value=66bdf875
Sig[6].Name=Exception Code
Sig[6].Value=c0000005
Sig[7].Name=Exception Offset
Sig[7].Value=00000000002c52aa
DynamicSig[1].Name=OS Version
DynamicSig[1].Value=10.0.22631.2.0.0.768.101
DynamicSig[2].Name=Locale ID
DynamicSig[2].Value=1033
DynamicSig[22].Name=Additional Information 1
DynamicSig[22].Value=5337
DynamicSig[23].Name=Additional Information 2
DynamicSig[23].Value=5337a5c17148cae16dc13b2e6d137d18
DynamicSig[24].Name=Additional Information 3
DynamicSig[24].Value=d391
DynamicSig[25].Name=Additional Information 4
DynamicSig[25].Value=d391bc2f5c08f33a2527ad05aa7a2222
UI[2]=C:\Users\barba\OneDrive\Documents\Godot_v4.3-stable_win64.exe
LoadedModule[0]=C:\Users\barba\OneDrive\Documents\Godot_v4.3-stable_win64.exe
LoadedModule[1]=C:\Windows\SYSTEM32\ntdll.dll
LoadedModule[2]=C:\Windows\System32\KERNEL32.DLL
LoadedModule[3]=C:\Windows\System32\KERNELBASE.dll
LoadedModule[4]=C:\Windows\System32\ADVAPI32.dll
LoadedModule[5]=C:\Windows\System32\msvcrt.dll
LoadedModule[6]=C:\Windows\System32\sechost.dll
LoadedModule[7]=C:\Windows\System32\bcrypt.dll
LoadedModule[8]=C:\Windows\System32\RPCRT4.dll
LoadedModule[9]=C:\Windows\System32\CRYPT32.dll
LoadedModule[10]=C:\Windows\System32\ucrtbase.dll
LoadedModule[11]=C:\Windows\System32\GDI32.dll
LoadedModule[12]=C:\Windows\System32\win32u.dll
LoadedModule[13]=C:\Windows\System32\gdi32full.dll
LoadedModule[14]=C:\Windows\System32\msvcp_win.dll
LoadedModule[15]=C:\Windows\System32\USER32.dll
LoadedModule[16]=C:\Windows\System32\IMM32.dll
LoadedModule[17]=C:\Windows\System32\ole32.dll
LoadedModule[18]=C:\Windows\SYSTEM32\DINPUT8.dll
LoadedModule[19]=C:\Windows\SYSTEM32\dbghelp.dll
LoadedModule[20]=C:\Windows\System32\combase.dll
LoadedModule[21]=C:\Windows\System32\OLEAUT32.dll
LoadedModule[22]=C:\Windows\SYSTEM32\AVRT.dll
LoadedModule[23]=C:\Windows\System32\SHELL32.dll
LoadedModule[24]=C:\Windows\SYSTEM32\dwmapi.dll
LoadedModule[25]=C:\Windows\System32\SHLWAPI.dll
LoadedModule[26]=C:\Windows\System32\WS2_32.dll
LoadedModule[27]=C:\Windows\SYSTEM32\DWrite.dll
LoadedModule[28]=C:\Windows\SYSTEM32\dxgi.dll
LoadedModule[29]=C:\Windows\SYSTEM32\IPHLPAPI.DLL
LoadedModule[30]=C:\Windows\SYSTEM32\WINMM.dll
LoadedModule[31]=C:\Windows\SYSTEM32\WSOCK32.dll
LoadedModule[32]=C:\Windows\System32\bcryptPrimitives.dll
LoadedModule[33]=C:\Windows\SYSTEM32\inputhost.dll
LoadedModule[34]=C:\Windows\SYSTEM32\CoreMessaging.dll
LoadedModule[35]=C:\Windows\System32\shcore.dll
LoadedModule[36]=C:\Windows\SYSTEM32\kernel.appcore.dll
LoadedModule[37]=C:\Windows\system32\uxtheme.dll
LoadedModule[38]=C:\Windows\SYSTEM32\CRYPTBASE.DLL
LoadedModule[39]=C:\Windows\System32\DriverStore\FileRepository\asusscreenxpertbase.inf_amd64_5a99711b059c5922\AsusScreenXpertBase\AsusWallpaperSettingHook.dll
LoadedModule[40]=C:\Users\barba\OneDrive\Documents\new-game-project\addons\orchestrator\~orchestrator.windows.64.release.dll
LoadedModule[41]=C:\Windows\SYSTEM32\MSVCP140.dll
LoadedModule[42]=C:\Windows\SYSTEM32\VCRUNTIME140_1.dll
LoadedModule[43]=C:\Windows\SYSTEM32\VCRUNTIME140.dll
LoadedModule[44]=C:\Windows\SYSTEM32\vulkan-1.dll
LoadedModule[45]=C:\Windows\SYSTEM32\CFGMGR32.dll
LoadedModule[46]=C:\Windows\SYSTEM32\dxcore.dll
LoadedModule[47]=C:\Windows\SYSTEM32\windows.staterepositorycore.dll
LoadedModule[48]=C:\Windows\SYSTEM32\directxdatabasehelper.dll
LoadedModule[49]=C:\Program Files\WindowsApps\Microsoft.D3DMappingLayers_1.2406.1.0_x64__8wekyb3d8bbwe\x64\vulkan_dzn.dll
LoadedModule[50]=C:\Windows\SYSTEM32\VERSION.dll
LoadedModule[51]=C:\Windows\System32\DriverStore\FileRepository\nvam.inf_amd64_9150b571262c1b17\nvoglv64.dll
LoadedModule[52]=C:\Windows\System32\SETUPAPI.dll
LoadedModule[53]=C:\Windows\SYSTEM32\WTSAPI32.dll
LoadedModule[54]=C:\Windows\SYSTEM32\msasn1.dll
LoadedModule[55]=C:\Windows\SYSTEM32\cryptnet.dll
LoadedModule[56]=C:\Windows\SYSTEM32\drvstore.dll
LoadedModule[57]=C:\Windows\SYSTEM32\devobj.dll
LoadedModule[58]=C:\Windows\SYSTEM32\wldp.dll
LoadedModule[59]=C:\Windows\System32\WINTRUST.dll
LoadedModule[60]=C:\Windows\SYSTEM32\ntmarta.dll
LoadedModule[61]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igvk64.dll
LoadedModule[62]=C:\Windows\system32\OpenGL32.dll
LoadedModule[63]=C:\Windows\SYSTEM32\GLU32.dll
LoadedModule[64]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igdgmm64.dll
LoadedModule[65]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igc64.dll
LoadedModule[66]=C:\Windows\System32\clbcatq.dll
LoadedModule[67]=C:\Windows\System32\WinTypes.dll
LoadedModule[68]=C:\Windows\SYSTEM32\rometadata.dll
LoadedModule[69]=C:\Program Files\WindowsApps\Microsoft.D3DMappingLayers_1.2406.1.0_x64__8wekyb3d8bbwe\x64\DXIL.dll
LoadedModule[70]=C:\Windows\SYSTEM32\d3d12.dll
LoadedModule[71]=C:\Program Files\WindowsApps\Microsoft.D3DMappingLayers_1.2406.1.0_x64__8wekyb3d8bbwe\x64\D3D12Core.dll
LoadedModule[72]=C:\Windows\SYSTEM32\windows.storage.dll
LoadedModule[73]=C:\Windows\system32\nvspcap64.dll
LoadedModule[74]=C:\Windows\SYSTEM32\profapi.dll
LoadedModule[75]=C:\Windows\SYSTEM32\ControlLib.dll
LoadedModule[76]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\IntelControlLib.dll
LoadedModule[77]=C:\Windows\System32\DriverStore\FileRepository\nvam.inf_amd64_9150b571262c1b17\nvldumdx.dll
LoadedModule[78]=C:\Windows\System32\imagehlp.dll
LoadedModule[79]=C:\Windows\SYSTEM32\CRYPTSP.dll
LoadedModule[80]=C:\Windows\system32\rsaenh.dll
LoadedModule[81]=C:\Windows\System32\DriverStore\FileRepository\nvam.inf_amd64_9150b571262c1b17\nvwgf2umx.dll
LoadedModule[82]=C:\Windows\System32\DriverStore\FileRepository\nvam.inf_amd64_9150b571262c1b17\Display.NvContainer\MessageBus.dll
LoadedModule[83]=C:\Windows\System32\NSI.dll
LoadedModule[84]=C:\Windows\SYSTEM32\dhcpcsvc.DLL
LoadedModule[85]=C:\Windows\SYSTEM32\D3DSCache.dll
LoadedModule[86]=C:\Windows\SYSTEM32\USERENV.dll
LoadedModule[87]=C:\Windows\SYSTEM32\twinapi.appcore.dll
LoadedModule[88]=C:\Windows\SYSTEM32\DComp.DLL
LoadedModule[89]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igd12umd64.dll
LoadedModule[90]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igd12um64xel.dll
LoadedModule[91]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igd12dxva64.dll
LoadedModule[92]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\media_bin_64.dll
LoadedModule[93]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igdinfo64.dll
LoadedModule[94]=C:\Windows\SYSTEM32\d3d10warp.dll
LoadedModule[95]=C:\Windows\System32\MSCTF.dll
LoadedModule[96]=C:\Windows\SYSTEM32\textinputframework.dll
LoadedModule[97]=C:\Windows\SYSTEM32\CoreUIComponents.dll
LoadedModule[98]=C:\Windows\system32\Oleacc.dll
LoadedModule[99]=C:\Windows\SYSTEM32\PROPSYS.dll
LoadedModule[100]=C:\Windows\SYSTEM32\XInput1_4.dll
LoadedModule[101]=C:\Windows\SYSTEM32\HID.DLL
LoadedModule[102]=C:\Windows\SYSTEM32\gpapi.dll
LoadedModule[103]=C:\Windows\System32\DriverStore\FileRepository\nvam.inf_amd64_9150b571262c1b17\NvCamera\NvCameraAllowlisting64.dll
LoadedModule[104]=C:\Windows\System32\DispBroker.dll
LoadedModule[105]=C:\Windows\SYSTEM32\nvapi64.dll
LoadedModule[106]=C:\Windows\System32\MMDevApi.dll
LoadedModule[107]=C:\Windows\SYSTEM32\AUDIOSES.DLL
LoadedModule[108]=C:\Windows\SYSTEM32\resourcepolicyclient.dll
LoadedModule[109]=C:\Windows\SYSTEM32\powrprof.dll
LoadedModule[110]=C:\Windows\SYSTEM32\UMPDC.dll
LoadedModule[111]=C:\Windows\System32\AppXDeploymentClient.dll
LoadedModule[112]=C:\Windows\System32\Windows.ApplicationModel.dll
LoadedModule[113]=C:\Windows\system32\mssprxy.dll
LoadedModule[114]=C:\Windows\SYSTEM32\WINSTA.dll
LoadedModule[115]=C:\Windows\system32\d3d11.dll
LoadedModule[116]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igd10iumd64.dll
LoadedModule[117]=C:\Windows\SYSTEM32\apphelp.dll
LoadedModule[118]=C:\Windows\System32\DriverStore\FileRepository\iigd_dch.inf_amd64_9741ef1f4093481f\igd10um64xe.DLL
LoadedModule[119]=C:\Windows\SYSTEM32\dhcpcsvc6.DLL
LoadedModule[120]=C:\Windows\SYSTEM32\DNSAPI.dll
State[0].Key=Transport.DoneStage1
State[0].Value=1
OsInfo[0].Key=vermaj
OsInfo[0].Value=10
OsInfo[1].Key=vermin
OsInfo[1].Value=0
OsInfo[2].Key=verbld
OsInfo[2].Value=22631
OsInfo[3].Key=ubr
OsInfo[3].Value=4037
OsInfo[4].Key=versp
OsInfo[4].Value=0
OsInfo[5].Key=arch
OsInfo[5].Value=9
OsInfo[6].Key=lcid
OsInfo[6].Value=1033
OsInfo[7].Key=geoid
OsInfo[7].Value=244
OsInfo[8].Key=sku
OsInfo[8].Value=101
OsInfo[9].Key=domain
OsInfo[9].Value=0
OsInfo[10].Key=prodsuite
OsInfo[10].Value=768
OsInfo[11].Key=ntprodtype
OsInfo[11].Value=1
OsInfo[12].Key=platid
OsInfo[12].Value=10
OsInfo[13].Key=sr
OsInfo[13].Value=0
OsInfo[14].Key=tmsi
OsInfo[14].Value=222812702
OsInfo[15].Key=osinsty
OsInfo[15].Value=1
OsInfo[16].Key=iever
OsInfo[16].Value=11.1.22621.0-11.0.1000
OsInfo[17].Key=portos
OsInfo[17].Value=0
OsInfo[18].Key=ram
OsInfo[18].Value=32373
OsInfo[19].Key=svolsz
OsInfo[19].Value=951
OsInfo[20].Key=wimbt
OsInfo[20].Value=0
OsInfo[21].Key=blddt
OsInfo[21].Value=220506
OsInfo[22].Key=bldtm
OsInfo[22].Value=1250
OsInfo[23].Key=bldbrch
OsInfo[23].Value=ni_release
OsInfo[24].Key=bldchk
OsInfo[24].Value=0
OsInfo[25].Key=wpvermaj
OsInfo[25].Value=0
OsInfo[26].Key=wpvermin
OsInfo[26].Value=0
OsInfo[27].Key=wpbuildmaj
OsInfo[27].Value=0
OsInfo[28].Key=wpbuildmin
OsInfo[28].Value=0
OsInfo[29].Key=osver
OsInfo[29].Value=10.0.22621.4037.amd64fre.ni_release.220506-1250
OsInfo[30].Key=buildflightid
OsInfo[31].Key=edition
OsInfo[31].Value=Core
OsInfo[32].Key=ring
OsInfo[32].Value=Retail
OsInfo[33].Key=expid
OsInfo[33].Value=RS:1F24A,MD:283BAEF,ME:2E3922F,FX:13023E93,ME:2E30985,FX:13127526,ME:2E30A2A,FX:1316017C,MD:3036FD6,FX:031B697B
OsInfo[34].Key=fconid
OsInfo[34].Value=15546617,1,2,1;19193777,0,2,0;19638787,0,2,0;23531064,2,2,0;23562335,2,2,0;23563673,2,2,0;26742989,0,1,0;32862274,0,2,0;34853379,0,0,1;35681102,0,1,0;36803287,0,2,1;36803295,0,2,0;36803303,0,2,1;38277973,0,1,0;38859191,0,2,0;39145991,0,2,0;39263329,1,2,0;39281392,0,2,0;39448330,1,2,0;40025975,0,1,0;40616880,0,1,0;40883769,0,1,0;40981503,0,1,0;41135193,0,1,1;41137130,0,1,0;41267076,0,2,0;41342175,0,1,0;41655236,0,2,0;41772259,0,2,0;42052423,0,2,0;42105254,0,2,0;42287267,0,2,1;42607764,0,2,0;42963857,0,2,1;43133808,1,2,1;43169616,0,1,0;43203978,0,2,1;43231896,0,0,1;43572857,0,2,0;43729363,0,2,1;43772553,0,1,0;43844371,0,1,0;43978769,0,1,0;43998261,0,2,1;44063183,0,2,0;44325080,0,1,0;44470355,0,2,0;44521793,0,1,0;44552141,0,1,0;44776738,0,2,0;45009259,0,1,0;45113694,0,2,1;45185354,0,2,0;45286373,0,1,0;45732051,0,2,0;45786062,0,2,0;45786681,0,2,1;45796396,0,2,0;45991456,0,1,1;46009617,0,2,1;46094352,0,0,1;46111200,0,2,1;46251949,0,2,0;46457961,0,1,0;46541070,0,2,0;46551074,0,1,0;46557400,0,1,0;46604216,0,2,1;46619189,0,2,0;46656382,0,2,1;46701147,0,2,0;46717502,0,2,0;46982417,0,2,0;46984166,0,2,1;47115450,0,1,0;47134595,0,1,0;47205155,0,2,0;47268464,2,2,0;47270778,0,2,1;47370305,0,2,1;47381523,0,2,1;47526873,1,2,1;47681899,0,1,0;47916854,0,1,0;47921574,0,2,1;47942561,0,2,0;47973375,0,1,0;47991031,0,2,1;48042498,0,2,1;48057519,0,2,0;48082515,0,2,0;48128028,0,2,0;48130544,0,2,0;48281163,0,0,0;48296377,0,1,0;48433541,0,2,1;48433706,0,2,1;48433719,0,1,0;48468527,0,2,1;48468541,0,2,0;48503047,0,2,0;48540091,0,2,1;48660958,0,2,1;48662857,0,2,0;48786216,0,2,1;48797684,0,0,1;48818825,0,2,1;48917127,0,2,0;48969045,0,2,0;49006888,0,1,1;49084341,0,1,1;49106743,0,2,0;49175271,0,2,0;49204591,0,1,1;49239926,0,1,0;49287050,0,2,1;49309588,0,1,0;49336997,0,2,1;49408394,0,1,1;49577493,0,1,0;49615603,0,1,0;49666091,0,0,0;49689210,0,1,1;49822061,0,1,0;50047324,0,2,0;50174317,1,2,0;50174338,0,1,1;50223223,0,2,1;50480279,0,1,0;50556886,0,0,1;50557073,0,1,0;50564196,0,1,0;50564332,0,1,0;50565209,0,1,0;50565295,0,1,0;50569047,0,2,0;50762615,0,1,0
OsInfo[35].Key=containerid
OsInfo[36].Key=containertype
OsInfo[37].Key=edu
OsInfo[37].Value=0
OsInfo[38].Key=servicinginprogress
OsInfo[38].Value=0
OsInfo[39].Key=featureupdatependingreboot
OsInfo[39].Value=0
FriendlyEventName=Stopped working
ConsentKey=APPCRASH
AppName=Godot Engine
AppPath=C:\Users\barba\OneDrive\Documents\Godot_v4.3-stable_win64.exe
NsPartner=windows
NsGroup=windows8
ApplicationIdentity=54C12176475F94661D793D1189D4DDD8
MetadataHash=1840195699
Naros commented 2 months ago

Hi @elmustardo would you be willing to download each of these pre-releases from 2.1 and let me know which ones work and which do not and cause crashes? Perhaps that will help us to identify where the regression may have been introduced:

Requires Godot 4.2:

Requires Godot 4.3.beta2 or later

elmustardo commented 2 months ago

@Naros I've tested each with a new project

godot-orchestrator-v2.1-dev1-plugin - Works

godot-orchestrator-v2.1-dev2-plugin - Works

godot-orchestrator-v2.1-dev3-plugin - Works

godot-orchestrator-v2.1-dev4-plugin - Works

godot-orchestrator-v2.1-rc2-plugin - Works

godot-orchestrator-v2.1-rc3-plugin - Works

godot-orchestrator-v2.1-rc4-plugin - CRASH

Naros commented 2 months ago

Excellent, thanks @elmustardo, time to dig into what changed between the two, I'll let you know what I find.

Naros commented 2 months ago

Here are some commits between 2.1.rc3 and 2.1.rc4, can you verify if these demo projects do or do not run @elmustardo ?

godot-orchestrator-demo-windows-release-24eb6e7.zip

godot-orchestrator-demo-windows-release-46dc432.zip

elmustardo commented 2 months ago

Here you go @Naros

godot-orchestrator-demo-windows-release-24eb6e7 -- CRASH

godot-orchestrator-demo-windows-release-46dc432 - Works

Naros commented 2 months ago

Hi @elmustardo, can you check this one for me:

godot-orchestrator-demo-windows-release-75ff266.zip

I appreciate the help remotely bisecting where the commit failure is, not sure why it doesn't fail on Windows 11.

elmustardo commented 2 months ago

@Naros For sure man. That one crashes for me as well.

Computer / Windows Specs if needed image

image

Naros commented 2 months ago

Ok lets try these @elmustardo, we're getting close

godot-orchestrator-demo-windows-release-a0f141c.zip

godot-orchestrator-demo-windows-release-d9354f9.zip

elmustardo commented 2 months ago

@Naros

godot-orchestrator-demo-windows-release-a0f141c - CRASH

godot-orchestrator-demo-windows-release-d9354f9 - CRASH

Naros commented 2 months ago

Ok, one last check @elmustardo, this will tell me which commit is the offender :)

godot-orchestrator-demo-windows-release-f9892fb.zip

elmustardo commented 2 months ago

@Naros That one worked

Naros commented 2 months ago

Awesome, so the offender is http://github.com/CraterCrash/godot-orchestrator/commit/9a5e5d53f38d57c93299227c4d7526583384f8ed, looking into the details of why.

Can you confirm this file does or does not exist in your installation:

res://addons/orchestrator/icons/Orchestrator_16x16.png
elmustardo commented 2 months ago

It does

Naros commented 2 months ago

Ok @elmustardo does this demo work for you? If so, I'll prepare to cut a 2.1.1 tomorrow based on this change.

godot-orchestrator-demo-windows-release-pr-778.zip

elmustardo commented 2 months ago

Negative - This one is still crasthing. @Naros

Naros commented 2 months ago

OK, thanks for confirming. In that case I'll revert the entire change in GH-653, thanks for confirming 👍

elmustardo commented 2 months ago

Right on man. Happy to help!

Naros commented 2 months ago

Do you have any .os files in your project? If so, do you notice that the FileSystemDock scans and only gets partially to 100% before Godot crashes @elmustardo ?

elmustardo commented 2 months ago

@Naros there are not. I test with a brand new project each time, dropping in the addon folder. image