Incompat with Truly Modular

CravenCraft / BetterParagliders

A compat mod to implement Paraglider's stamina system with Better Combat attacks

MIT License

2 stars 0 forks source link

Open Smartin-b opened 3 months ago

Smartin-b commented 3 months ago

At the moment Better Paragliders doesnt resolve its attribute from the Itemstack instance, but the Item. This should be changed to utilize the Itemstack function instead, so Mods can have Items with changing Attackdamage. https://github.com/CravenCraft/BetterParagliders/blob/805f9440b3e1f16647eb675e512fd58662096f95/src/main/java/net/cravencraft/betterparagliders/utils/CalculateStaminaUtils.java#L75

CravenCraft commented 3 months ago

Oh wow good find. I wasn't even aware that would be an issue. Should be a super easy fix I can throw into a patch soon

Gai-fan commented 2 months ago

Oh wow good find. I wasn't even aware that would be an issue. Should be a super easy fix I can throw into a patch soon

Have you already forgotten about this? I hope it can be resolved as soon as possible. Thank you