Cray-HPE / loftsman

Define, organize, and ship your Kubernetes workloads with Helm charts easily

MIT License

9 stars 5 forks source link

adjust reacting to whether a helm repo chart url in the index is full… #36

Closed rockholla closed 3 years ago

rockholla commented 3 years ago

… or relative in a more generic way, able to capture all cases

What type of PR is this?

a hotfix

What this PR does / why we need it:

fix cases of helm repos serving alternative urls/locations for indexed charts. I've also added a test around this to the functional tests.

Which issue(s) this PR fixes or finishes:

34

rockholla commented 3 years ago

Also adjusting the unit tests script, go mod suddenly started not liking the go get of golint in the root directory of the repo. Noticed this on another project doing something similar this past week.

zcrisler commented 3 years ago

Seems like the test that failed should have been skipped?

rockholla commented 3 years ago

Seems like the test that failed should have been skipped?

Sorry, not following I think. Might be just b/c I was trying to fix this unit test script issue concurrently :) Can you point to the expected skipped test you're talking about?

zcrisler commented 3 years ago

I don't see it under checks anymore. It looked like it failed trying to make a release due to a missing change log entry.

rockholla commented 3 years ago

I don't see it under checks anymore. It looked like it failed trying to make a release due to a missing change log entry.

Ah yeah, I was tagging a pre-release along with this and didn't have a changelog for it, fixed/pushed along with these changes: https://github.com/Cray-HPE/loftsman/pull/36/commits/33b819bce7922b61b94d6cc0f42686c4a0c50256