Improve the unit tests for ContainerStopProcess. The main improvement is that we change the way that the unit tests verify whether the process was successful by checking the values added to the results_queue instead of looking at the success attribute, which will not be visible to the parent process.
Additionally, change thread to process where appropriate in naming of variables. E.g., change cst to csp for ContainerStopProcess instead of ContainerStopThread.
Issues and Related PRs
Part of CRAYSAT-1100
Testing
Tested on:
Local macbook
Test description:
Unit tests pass.
Risks and Mitigations
Low risk unit test improvements.
Pull Request Checklist
[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
Summary and Scope
Improve the unit tests for ContainerStopProcess. The main improvement is that we change the way that the unit tests verify whether the process was successful by checking the values added to the
results_queue
instead of looking at thesuccess
attribute, which will not be visible to the parent process.Additionally, change thread to process where appropriate in naming of variables. E.g., change
cst
tocsp
forContainerStopProcess
instead ofContainerStopThread
.Issues and Related PRs
Testing
Tested on:
Test description:
Unit tests pass.
Risks and Mitigations
Low risk unit test improvements.
Pull Request Checklist