CRAYSAT-1330: Specify image name directly in CFS session when possible

haasken-hpe commented 3 months ago

Summary and Scope

CRAYSAT-1330: Specify image name directly in CFS session when possible

When possible, specify the desired resulting image name directly when creating the CFS session instead of requiring a costly and failure-prone image rename operation after the CFS configuration has been completed.

This greatly improves the reliability and performance of sat bootprep for image customization.

Test Description: Not tested yet.
CRAYSAT-1330: Update to version 2.0.0 of csm-api-client

Version 2.0.0 of csm-api-client introduces the ability to specify the name of images when images are customized in CFS.

Issues and Related PRs

Resolves CRAYSAT-1330
Requires merge of Cray-HPE/python-csm-api-client#30

Testing

Tested on:

rocket

Test description:

Created a build of the sat container image and tested as follows:

Created a bootprep file that builds and customizes an image from the CSM barebones image. Also tested the same thing but with it building the image from recipe first.

Verified that the CFS session specified the destination image name, and that SAT didn't have to rename the image. Verified that the image existed afterwards.

Risks and Mitigations

This has the same risks as mentioned in Cray-HPE/python-csm-api-client#30

Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable
[x] Remove commit that uses unstable builds of csm-api-client when stable build is published

shivaprasad-metimath commented 3 months ago

License check seems to be failing, need to update the year in the files

haasken-hpe commented 3 months ago

License check seems to be failing, need to update the year in the files

It just failed on the Dockerfile, and I'm going to remove the commit that changes that file anyway now that I have a stable 2.0.0 build of csm-api-client.

haasken-hpe commented 3 months ago

I do need a changelog update though, oops!

Cray-HPE / sat