CRAYSAT-1884: Updating cray-product-catalog & csm-api-client to latest versions

Cray-HPE / sat

System Admin Toolkit

https://cray-hpe.github.io/docs-sat/

MIT License

4 stars 5 forks source link

CRAYSAT-1884: Updating cray-product-catalog & csm-api-client to latest versions #258

Closed shivaprasad-metimath closed 1 month ago

shivaprasad-metimath commented 2 months ago

Summary and Scope

Updating cray-product-catalog & csm-api-client to latest versions

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CRAYSAT-1884

Testing

List the environments in which these changes were tested.

Tested on:

Rocket,Gamora,Surtur

Test description:

Test the below SAT utilities sat showrev --products sat bootprep cfs-config-util

Risks and Mitigations

Minimal

Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

shivaprasad-metimath commented 1 month ago

Testing was done on surtur,rocket for lower versions than 2.3.1 and for 2.3.1 it was tested on gamora system. Sat showrev,bootprep were tested along with cfs-config-util. Below is the link to complete output: https://gist.github.com/shivaprasad-metimath/432dbacecaa4346b011777dc5863ec80

shivaprasad-metimath commented 1 month ago

Partially you are on track. The code changes looks good to me. But, you have to update new version of cray-product-catalog in cfs-config-util repository, get the new unstable build and test with cfs-config-util commands. Testing cfs-config-util commands with this build doesn't make sense to me.

Ok, the testing for cfs-config-util will be done with new unstable build in respective repo. are this repo specific testing satisfactory? Let me know if any comments, else will proceed with merging this PR and raise a separate one for cfs-config-util repo

annapoorna-s-alt commented 1 month ago

Partially you are on track. The code changes looks good to me. But, you have to update new version of cray-product-catalog in cfs-config-util repository, get the new unstable build and test with cfs-config-util commands. Testing cfs-config-util commands with this build doesn't make sense to me.

Ok, the testing for cfs-config-util will be done with new unstable build in respective repo. are this repo specific testing satisfactory? Let me know if any comments, else will proceed with merging this PR and raise a separate one for cfs-config-util repo

Yes, the other testings are pretty good. But once the PR on cfs-config-util merges, I would request you to do sanity tests on this repo as the version updates are critical. Then you feel free to merge