CRAYSAT-1912: Get K8s version from node-images

haasken-hpe commented 2 weeks ago

Summary and Scope

Update the cray-sat image build process to get the Kubernetes version from its new location in the node-images repository instead of the old version in the deprecated metal-provision repository.

This is more involved than just changing the repository URL and path in the docker_scripts/config-docker-sat.sh script because the node-images repository is private in GitHub, but metal-provision was public. Thus we need to authenticate to GitHub when cloning this repository. This is best achieved through a git command in the Jenkinsfile.

In order to continue supporting local builds, add a target to the Makefile that clones the node-images repository if it does not already exist. Use the git protocol instead of https to allow it to use the user's configured SSH keypair to authenticate when cloning the repo.

In either case, the node-images repository gets bind-mounted during the RUN command, so that it can be accessed by the config-docker-sat.sh script.

Issues and Related PRs

Resolves CRAYSAT-1912

Testing

Tested on:

Local development environment
Jenkins

Test description:

Built the image locally using make image. Then ran the container and executed kubectl version to verify the version of the kubectl client that was installed.

Pushed to Jenkins and verified that the Jenkins pipeline worked.

Risks and Mitigations

Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

haasken-hpe commented 2 weeks ago

Before merge, we should test the few important places where we use kubectl. In order of importance:

Branch to commit resolution in sat bootprep
Image customization in sat bootprep

shivaprasad-metimath commented 2 weeks ago

@annapoorna-s-alt testing results: https://gist.github.com/annapoorna-s-alt/45736c9032a583c3bf5dc972acb60e7e

The testing looks good, hence proceeding with merging the PR

Cray-HPE / sat