CRAYSAT-1917: Fix jinja2 rendering of boot_sets data in `sat bootprep`

annapoorna-s-alt commented 1 month ago

Summary and Scope

Make the following fixes:

Remove the boot_set property from BaseInputItem. It is not appropriate there, and it is redundant with boot_sets property that already exists in the InputSessionTemplate
Modify the jinja_rendered decorator to recursively render more complex objects like lists and dictionaries. I think this is safe, but we should consider any edge cases more carefully.
Remove the now unnecessary code that does a one-off Jinja2 rendering of rootfs_provider_passthrough in the boot_sets.

Could still use unit test enhancements that test this new ability to render fields in the boot_sets.

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CRAYSAT-1917

Testing

List the environments in which these changes were tested.

Tested on:

starlord

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Tested on a simple bootprep input file that used a variable in the rootfs_provider_passthrough field of a boot set in a BOS session template.

Risks and Mitigations

Low

Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

annapoorna-s-alt commented 1 month ago

Testing output on starlord- https://gist.github.com/annapoorna-s-alt/981715de25d248527c7200d50398c731

annapoorna-s-alt commented 1 month ago

Adding unit tests are pending

shivaprasad-metimath commented 1 month ago

Core functionality is tested. Need to update the unit tests for the same.

@annapoorna-s-alt - Would take the ticket forward, as she has tested the draft PR

annapoorna-s-alt commented 1 month ago

Output of testing other fields in the boot_sets support Jinja2 rendering - https://gist.github.com/annapoorna-s-alt/981715de25d248527c7200d50398c731#file-expand-other-fields-with-jinja

haasken-hpe commented 3 weeks ago

Output of testing other fields in the boot_sets support Jinja2 rendering - https://gist.github.com/annapoorna-s-alt/981715de25d248527c7200d50398c731#file-expand-other-fields-with-jinja

This testing looks good.

annapoorna-s-alt commented 2 weeks ago

/backport release/3.32

github-actions[bot] commented 2 weeks ago

Backporting into branch release/3.32 was successful. New PR: https://github.com/Cray-HPE/sat/pull/284

Cray-HPE / sat