Cray-HPE / sat

System Admin Toolkit
https://cray-hpe.github.io/docs-sat/
MIT License
4 stars 5 forks source link

CRAYSAT-1935: create_image_customization_session() missing `image_name` argument #286

Closed annapoorna-s-alt closed 2 weeks ago

annapoorna-s-alt commented 2 weeks ago

Summary and Scope

Traceback Error - "TypeError: create_image_customization_session() missing 1 required positional argument: 'image_name'" has been observed with the latest stable build of release/3.25

To fix this, Backport CRAYSAT-1747: Allow passing CFS session name to SAT 2.6 / CSM 1.5 as a solution

Incorrect logging is observed in sat bootprep logs SAT is also generating a session name, which is conflicting with session name generated in create_image_customization_session

Hence updating the begin_image_configure to pass session name to address sat bootprep incorrect logging

(cherry picked from commit e35ac289cfac844d98727f715c742248ce9239e7)

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

List the environments in which these changes were tested.

Tested on:

rocket

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Test the unstable build to create the images successfully from sat bootprep command without any Traceback error

Risks and Mitigations

Are there known issues with these changes? Any other special considerations?

Pull Request Checklist

annapoorna-s-alt commented 2 weeks ago

Testing output: https://gist.github.com/annapoorna-s-alt/11628462dc73a84b4adaf63c02984fdc