search

CrayLabs / SmartDashboard

SmartSim Dashboard Package.
BSD 2-Clause "Simplified" License
6 stars 2 forks source link

Refactor view_builders #21

Closed AlyssaCote closed 1 year ago

AlyssaCote commented 1 year ago

In this PR I added build_dataframe_generic and build_dataframe_loaded_entities (I could use help on naming!) I separated them because they do not build dataframes in the same way. I am hesitant to try to get this in before code freeze because it does touch a lot of the rendering dashboard code.

AlyssaCote commented 1 year ago

LGTM! One quick question, unrelated to the PR but in the same file: view_builders.py lines 271 to 275 seems to be writing four blank lines? Is that really needed or was this debug code that crept in?

That's necessary spacing in the dashboard. I added a helper function that handles the spacing and explains it a little better for clarity.