CrayLabs / SmartDashboard

SmartSim Dashboard Package.
BSD 2-Clause "Simplified" License
6 stars 2 forks source link

Adjust status enums #41

Closed AlyssaCote closed 7 months ago

AlyssaCote commented 7 months ago

This PR addresses a status bug that occurred when Experiment Telemetry is disabled. If it's disabled, all statuses would read Pending even though those statuses would never show up. Because the dashboard can't know for sure whether the statuses will eventually come through, I thought that Unknown is a better fit for that state. If the dashboard can't read from the status directory (because of a KeyError or JSONDecodeError), the status read out as Unknown. Now that Unknown is being used in place of what used to be Pending, I added a new enum called Malformed that handles statuses in that state.

in short, UNKNOWN is now MALFORMED PENDING is now UNKNOWN