CrayLabs / SmartRedis

SmartSim Infrastructure Library Clients.
BSD 2-Clause "Simplified" License
54 stars 25 forks source link

Remove unused parameter model name in _get_model_script_db() #477

Closed mellis13 closed 7 months ago

mellis13 commented 7 months ago

This PR removes an unused parameter in RedisCluster::_get_model_script_db(). The comments for the function were also corrected to reflect the actual behavior of the function. It is worth noting that _get_model_script_db is not called currently in SmartRedis, but it was not removed because it was a precursor implementation for optimizing model execution.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.82%. Comparing base (51c3dc6) to head (1354021).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartRedis/pull/477/graphs/tree.svg?width=650&height=150&src=pr&token=XSS8CCJ2KR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartRedis/pull/477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## develop #477 +/- ## ======================================== Coverage 78.82% 78.82% ======================================== Files 97 97 Lines 7362 7362 ======================================== Hits 5803 5803 Misses 1559 1559 ``` | [Files](https://app.codecov.io/gh/CrayLabs/SmartRedis/pull/477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | Coverage Δ | | |---|---|---| | [src/cpp/rediscluster.cpp](https://app.codecov.io/gh/CrayLabs/SmartRedis/pull/477?src=pr&el=tree&filepath=src%2Fcpp%2Frediscluster.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c3JjL2NwcC9yZWRpc2NsdXN0ZXIuY3Bw) | `66.30% <0.00%> (ø)` | |