CrayLabs / SmartRedis

SmartSim Infrastructure Library Clients.

BSD 2-Clause "Simplified" License

54 stars 25 forks source link

Error with GCC 14.2.1 #504

Open LucasGasparinoBSC opened 2 months ago

LucasGasparinoBSC commented 2 months ago

Description

In '/home/lucas/Apps/Libraries/SMARTREDIS/SmartRedis/src/cpp/rediscluster.cpp', the compiler cannot find 'std::sort' (line 1246).

How to reproduce

Using GCC 14.2.1 + MPI 5.0.3 in Archlinux, run the 'make lib' command.

Expected behavior

It's just missing an '#include ' for the function to be recognised. No idea if this happens with other compilers, still testing.

System

OS: Garuda ArchLinux
OS version: latest
Commit/version of library: develop

mellis13 commented 2 months ago

Hello,

I merged a quick fix for the gcc-14 compilation error. With that fix, it looks like make lib should execute correctly without compilation errors. However, our testing infrastructure requires significant changes to add gcc-14 testing, and as a result, we won't be able to officially support gcc-14 for a couple of weeks until that is fixed. I've added another ticket #505 that will track this work. Let us know if you run into any issues!

ashao commented 1 month ago

@LucasGasparinoBSC Just following up on this again. It seems like RedisAI is not able to be built with GCC-14. Due to licensing issues with RedisAI, this may not be trivial for us to resolve. Are you able to compile with GCC<14 at BSC?

ashao commented 3 weeks ago

@LucasGasparinoBSC, I forgot to mention that we did address this and are now testing SmartRedis with GCC-14. Let me know if you're still running into problems.