CrayLabs / SmartRedis

SmartSim Infrastructure Library Clients.
BSD 2-Clause "Simplified" License
54 stars 25 forks source link

Add gcc-14 support #505

Closed mellis13 closed 1 month ago

mellis13 commented 1 month ago

This PR fixes a compilation error that will occur with gcc-14.

Note that gcc-14 was not added to the testing infrastructure because that would require the runners being bumped to ubuntu 24.04 which had some domino effects. This will be addressed in a future PR.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.07%. Comparing base (4937fbd) to head (dd05cca). Report is 3 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartRedis/pull/505/graphs/tree.svg?width=650&height=150&src=pr&token=XSS8CCJ2KR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartRedis/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## develop #505 +/- ## ============================================ - Coverage 95.92% 57.07% -38.86% ============================================ Files 10 147 +137 Lines 884 11248 +10364 Branches 0 1120 +1120 ============================================ + Hits 848 6420 +5572 - Misses 36 4677 +4641 - Partials 0 151 +151 ``` [see 137 files with indirect coverage changes](https://app.codecov.io/gh/CrayLabs/SmartRedis/pull/505/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)