CrayLabs / SmartSim

SmartSim Infrastructure Library.
BSD 2-Clause "Simplified" License
219 stars 36 forks source link

Move SmartSim v0.X.Y test to `tests/_legacy` dir #575

Closed MattToast closed 1 month ago

MattToast commented 1 month ago

Move the test suite used for SmartSim v0.X.Y to a tests/_legacy dir. This directory is explicitly skipped during test collection as these tests are not expected to pass as SmartSim transitions to a new user facing and core API.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (smartsim-refactor@f3a58d4). Learn more about missing BASE report.

:exclamation: Current head 8af7e4d differs from pull request most recent head fedff16

Please upload reports for the commit fedff16 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## smartsim-refactor #575 +/- ## ==================================================== Coverage ? 32.39% ==================================================== Files ? 66 Lines ? 4571 Branches ? 0 ==================================================== Hits ? 1481 Misses ? 3090 Partials ? 0 ```
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Please upload report for BASE (smartsim-refactor@f3a58d4). Learn more about missing BASE report.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## smartsim-refactor #575 +/- ## ==================================================== Coverage ? 30.92% ==================================================== Files ? 78 Lines ? 6014 Branches ? 0 ==================================================== Hits ? 1860 Misses ? 4154 Partials ? 0 ``` | [Files](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | Coverage Δ | | |---|---|---| | [smartsim/\_core/control/controller.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2F_core%2Fcontrol%2Fcontroller.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvY29udHJvbC9jb250cm9sbGVyLnB5) | `16.99% <ø> (ø)` | | | [smartsim/\_core/control/jobmanager.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2F_core%2Fcontrol%2Fjobmanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvY29udHJvbC9qb2JtYW5hZ2VyLnB5) | `23.22% <100.00%> (ø)` | | | [smartsim/\_core/launcher/launcher.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Flauncher.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvbGF1bmNoZXIucHk=) | `100.00% <100.00%> (ø)` | | | [smartsim/\_core/launcher/local/local.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Flocal%2Flocal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvbG9jYWwvbG9jYWwucHk=) | `35.55% <100.00%> (ø)` | | | [smartsim/\_core/launcher/step/localStep.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Fstep%2FlocalStep.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvc3RlcC9sb2NhbFN0ZXAucHk=) | `35.00% <100.00%> (ø)` | | | [smartsim/\_core/launcher/step/mpiStep.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Fstep%2FmpiStep.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvc3RlcC9tcGlTdGVwLnB5) | `35.61% <100.00%> (ø)` | | | [smartsim/\_core/launcher/step/step.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Fstep%2Fstep.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvc3RlcC9zdGVwLnB5) | `42.30% <100.00%> (ø)` | | | [smartsim/entity/dbnode.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2Fentity%2Fdbnode.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vZW50aXR5L2Ribm9kZS5weQ==) | `36.75% <100.00%> (ø)` | | | [smartsim/settings/base.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2Fsettings%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vc2V0dGluZ3MvYmFzZS5weQ==) | `42.36% <ø> (ø)` | | | [smartsim/settings/settings.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree&filepath=smartsim%2Fsettings%2Fsettings.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vc2V0dGluZ3Mvc2V0dGluZ3MucHk=) | `20.68% <0.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/575?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | |