CrayLabs / SmartSim

SmartSim Infrastructure Library.
BSD 2-Clause "Simplified" License
228 stars 36 forks source link

BatchSettings, LaunchSettings, Command, CommandList and LaunchCommand Refactor #587

Closed amandarichardsonn closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 59.90099% with 162 lines in your changes missing coverage. Please review.

Please upload report for BASE (smartsim-refactor@d058213). Learn more about missing BASE report.

:exclamation: Current head 72987b4 differs from pull request most recent head ffd95d7

Please upload reports for the commit ffd95d7 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## smartsim-refactor #587 +/- ## ==================================================== Coverage ? 33.09% ==================================================== Files ? 99 Lines ? 6191 Branches ? 0 ==================================================== Hits ? 2049 Misses ? 4142 Partials ? 0 ``` | [Files](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | Coverage Δ | | |---|---|---| | [smartsim/\_core/commands/\_\_init\_\_.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2F_core%2Fcommands%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvY29tbWFuZHMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [smartsim/\_core/launcher/step/localStep.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Fstep%2FlocalStep.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvc3RlcC9sb2NhbFN0ZXAucHk=) | `33.33% <100.00%> (ø)` | | | [smartsim/\_core/launcher/step/mpiStep.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Fstep%2FmpiStep.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvc3RlcC9tcGlTdGVwLnB5) | `34.72% <100.00%> (ø)` | | | [smartsim/\_core/launcher/step/step.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2F_core%2Flauncher%2Fstep%2Fstep.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbGF1bmNoZXIvc3RlcC9zdGVwLnB5) | `42.30% <100.00%> (ø)` | | | [smartsim/\_core/utils/helpers.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2F_core%2Futils%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvdXRpbHMvaGVscGVycy5weQ==) | `32.50% <100.00%> (ø)` | | | [smartsim/database/orchestrator.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2Fdatabase%2Forchestrator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vZGF0YWJhc2Uvb3JjaGVzdHJhdG9yLnB5) | `25.58% <ø> (ø)` | | | [smartsim/entity/dbnode.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2Fentity%2Fdbnode.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vZW50aXR5L2Ribm9kZS5weQ==) | `36.75% <100.00%> (ø)` | | | [smartsim/entity/ensemble.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2Fentity%2Fensemble.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vZW50aXR5L2Vuc2VtYmxlLnB5) | `27.94% <100.00%> (ø)` | | | [smartsim/entity/entity.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2Fentity%2Fentity.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vZW50aXR5L2VudGl0eS5weQ==) | `56.66% <ø> (ø)` | | | [smartsim/entity/model.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree&filepath=smartsim%2Fentity%2Fmodel.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vZW50aXR5L21vZGVsLnB5) | `32.38% <100.00%> (ø)` | | | ... and [21 more](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/587?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | |