CrayLabs / SmartSim

SmartSim Infrastructure Library.
BSD 2-Clause "Simplified" License
228 stars 36 forks source link

Remove device attribute from schemas #619

Closed AlyssaCote closed 3 months ago

AlyssaCote commented 3 months ago

This PR removes device from the schemas, MessageHandler, and tests.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (mli-feature@38081da). Learn more about missing BASE report.

:exclamation: Current head 568806b differs from pull request most recent head 96047fa

Please upload reports for the commit 96047fa to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/619/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/619?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## mli-feature #619 +/- ## ============================================== Coverage ? 63.50% ============================================== Files ? 91 Lines ? 6486 Branches ? 0 ============================================== Hits ? 4119 Misses ? 2367 Partials ? 0 ``` | [Files](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/619?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | Coverage Δ | | |---|---|---| | [.../\_core/mli/infrastructure/control/workermanager.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/619?src=pr&el=tree&filepath=smartsim%2F_core%2Fmli%2Finfrastructure%2Fcontrol%2Fworkermanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbWxpL2luZnJhc3RydWN0dXJlL2NvbnRyb2wvd29ya2VybWFuYWdlci5weQ==) | `18.10% <ø> (ø)` | | | [smartsim/\_core/mli/infrastructure/worker/worker.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/619?src=pr&el=tree&filepath=smartsim%2F_core%2Fmli%2Finfrastructure%2Fworker%2Fworker.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbWxpL2luZnJhc3RydWN0dXJlL3dvcmtlci93b3JrZXIucHk=) | `78.20% <ø> (ø)` | | | [smartsim/\_core/mli/message\_handler.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/619?src=pr&el=tree&filepath=smartsim%2F_core%2Fmli%2Fmessage_handler.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvbWxpL21lc3NhZ2VfaGFuZGxlci5weQ==) | `76.14% <ø> (ø)` | |
ankona commented 3 months ago

There is a test here that is likely silently failing because it provides an unexpected keyword arg. At minimum, you should just have to remove device=expected_device, but could also remove from the commented out tests in test_integrated_torch_worker.py, too