search

CrayLabs / SmartSim

SmartSim Infrastructure Library.
BSD 2-Clause "Simplified" License
228 stars 36 forks source link

Restrict to numpy 1.x #623

Closed ashao closed 3 months ago

ashao commented 3 months ago

The new major version release of Numpy is incompatible with modules compiled against Numpy 1.x. For both SmartSim and SmartRedis we request a 1.x version of numpy. This is needed in SmartSim because some of the downstream dependencies request NumPy.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.16%. Comparing base (0956399) to head (aef4f22). Report is 12 commits behind head on develop.

:exclamation: There is a different number of reports uploaded between BASE (0956399) and HEAD (aef4f22). Click for more details.

HEAD has 4 uploads less than BASE | Flag | BASE (0956399) | HEAD (aef4f22) | |------|------|------| ||6|2|
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/623/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## develop #623 +/- ## =========================================== - Coverage 66.23% 59.16% -7.08% =========================================== Files 83 83 Lines 6208 6208 =========================================== - Hits 4112 3673 -439 - Misses 2096 2535 +439 ``` [see 17 files with indirect coverage changes](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/623/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)