CrayLabs / SmartSim

SmartSim Infrastructure Library.
BSD 2-Clause "Simplified" License
235 stars 37 forks source link

Runtime value checking for LaunchSettings and BatchSettings #740

Open juliaputko opened 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 37.90%. Comparing base (cce16e6) to head (acd56da). Report is 19 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/settings/batch_settings.py 0.00% 5 Missing :warning:
smartsim/settings/launch_settings.py 40.00% 3 Missing :warning:
smartsim/settings/arguments/launch/dragon.py 0.00% 1 Missing :warning:
smartsim/settings/arguments/launch/local.py 0.00% 1 Missing :warning:
smartsim/settings/arguments/launch/mpi.py 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## smartsim-refactor #740 +/- ## ===================================================== - Coverage 40.45% 37.90% -2.56% ===================================================== Files 110 109 -1 Lines 7326 6583 -743 ===================================================== - Hits 2964 2495 -469 + Misses 4362 4088 -274 ``` | [Files with missing lines](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | Coverage Δ | | |---|---|---| | [smartsim/settings/arguments/launch/dragon.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740?src=pr&el=tree&filepath=smartsim%2Fsettings%2Farguments%2Flaunch%2Fdragon.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vc2V0dGluZ3MvYXJndW1lbnRzL2xhdW5jaC9kcmFnb24ucHk=) | `54.83% <0.00%> (-25.81%)` | :arrow_down: | | [smartsim/settings/arguments/launch/local.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740?src=pr&el=tree&filepath=smartsim%2Fsettings%2Farguments%2Flaunch%2Flocal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vc2V0dGluZ3MvYXJndW1lbnRzL2xhdW5jaC9sb2NhbC5weQ==) | `50.00% <0.00%> (-37.50%)` | :arrow_down: | | [smartsim/settings/arguments/launch/mpi.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740?src=pr&el=tree&filepath=smartsim%2Fsettings%2Farguments%2Flaunch%2Fmpi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vc2V0dGluZ3MvYXJndW1lbnRzL2xhdW5jaC9tcGkucHk=) | `43.02% <0.00%> (-52.33%)` | :arrow_down: | | [smartsim/settings/launch\_settings.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740?src=pr&el=tree&filepath=smartsim%2Fsettings%2Flaunch_settings.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vc2V0dGluZ3MvbGF1bmNoX3NldHRpbmdzLnB5) | `64.93% <40.00%> (ø)` | | | [smartsim/settings/batch\_settings.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740?src=pr&el=tree&filepath=smartsim%2Fsettings%2Fbatch_settings.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vc2V0dGluZ3MvYmF0Y2hfc2V0dGluZ3MucHk=) | `46.42% <0.00%> (ø)` | | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/740/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)