search

CrayLabs / SmartSim

SmartSim Infrastructure Library.
BSD 2-Clause "Simplified" License
235 stars 37 forks source link

`Experiment.start` Returns Records #744

Open MattToast opened 1 month ago

MattToast commented 1 month ago

Basic implementation of a Record class to keep track of launched jobs. Convert Experiment.start return Records and all other methods to accept records.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.0@879b96e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/launchable/job.py 86.66% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/744/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## v1.0 #744 +/- ## ======================================= Coverage ? 59.04% ======================================= Files ? 142 Lines ? 9140 Branches ? 0 ======================================= Hits ? 5397 Misses ? 3743 Partials ? 0 ``` | [Files with missing lines](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/744?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) | Coverage Δ | | |---|---|---| | [smartsim/\_core/utils/helpers.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/744?src=pr&el=tree&filepath=smartsim%2F_core%2Futils%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vX2NvcmUvdXRpbHMvaGVscGVycy5weQ==) | `41.66% <ø> (ø)` | | | [smartsim/experiment.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/744?src=pr&el=tree&filepath=smartsim%2Fexperiment.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vZXhwZXJpbWVudC5weQ==) | `88.53% <100.00%> (ø)` | | | [smartsim/launchable/job.py](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/744?src=pr&el=tree&filepath=smartsim%2Flaunchable%2Fjob.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs#diff-c21hcnRzaW0vbGF1bmNoYWJsZS9qb2IucHk=) | `93.84% <86.66%> (ø)` | |