CrayLabs / SmartSim

SmartSim Infrastructure Library.
BSD 2-Clause "Simplified" License
235 stars 37 forks source link

Fix logging bug in dragon_install #761

Closed AlyssaCote closed 4 weeks ago

AlyssaCote commented 1 month ago

I added extra logging depending on the type of mismatch between the asset and the platform. I also return None if the asset is a CRAY EX asset but the platform is not a CRAY EX platform. I broke it down into these potential situations:

is cray ex platform "crayex" in asset name Results (asset, log output)
True False asset, Platform-specific package not found. Using {asset.name}
True True asset, no log output
False False asset, no log output
False True None, Platform does not support Cray EX assets

NOTE: The string crayex that we check is in the asset name will need to be changed to hsn as soon as Matt's work goes in because the asset names now have hsn instead of crayex.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v1.0@5bdafc5). Learn more about missing BASE report.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/761/graphs/tree.svg?width=650&height=150&src=pr&token=96HFI2F45E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs)](https://app.codecov.io/gh/CrayLabs/SmartSim/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrayLabs) ```diff @@ Coverage Diff @@ ## v1.0 #761 +/- ## ======================================= Coverage ? 58.96% ======================================= Files ? 142 Lines ? 9126 Branches ? 0 ======================================= Hits ? 5381 Misses ? 3745 Partials ? 0 ```