Using /cc open <crate> breaks crates until /cc reload.

andrewkm commented 8 months ago

Spark link

No response

Server Version

1.20.4

Server Platform

Paper

Describe the bug

/cc open only works once then it breaks the crate. Issue /cc reload (fixes netherstar accepting crate once broken)

Have Nstars in hotbar slot 1 - use /cc open starmachine (it should work)
Use /cc open starmachine again (no longer accepts keys) Only an issue with the crates that take nstars - any crates with the tripwire hook keys are functioning normally with /cc open
/cc GUI also no longer takes the nstar key once broken. /- cc mass-open also no longer takes the nstar keys once broken. Starmachine will function as intended and work many times and not break if you use only /cc and spin the crate via the GUI and if you use only /cc mass-open starmachine p 1, once the /cc open starmachine command had been issued by anyone it breaks for everyone.

In the broken state however, netherstars taken from the /cc admin menu do work. This leads me to believe the old-key-checks option is somehow reverting to false after being used once via /cc open, and then /cc reload fixes it, until of course someone uses /cc open again.

https://youtu.be/aVEH_PTXHfA

Crate Type

CSGO

Steps to reproduce

See above.

Additional context

Using https://github.com/Crazy-Crew/CrazyCrates/commit/31d6a1b256772d1f49eeb23a9481763d7f0a66e2 Paper Build 462 Config.yml: https://pastebin.com/jC7FRGAs StarMachine: https://pastebin.com/2GtVJC5y

Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[ ] I ticked all the boxes without actually reading them
[X] My version of Minecraft is supported by CrazyCrew.

andrewkm commented 8 months ago

This one is still broken on our end.

andrewkm commented 7 months ago

Thanks for re-opening, I will attempt to do more in-depth tests to see if we can track this down in-case you still cannot reproduce. Perhaps some sort of debug would be helpful as well.

andrewkm commented 7 months ago

After testing we've determined; setting either of the following options to true causes this issue: log-console: false log-file: false

ryderbelserion commented 2 months ago

Fixed this issue, and added the ability to log to console/file back in https://github.com/Crazy-Crew/CrazyCrates/compare/d27c013796b3...d8daa0758a4a

andrewkm commented 1 month ago

Confirmed fixed! :)

Crazy-Crew / CrazyCrates