search

Crazy-Crew / CrazyEnchantments

Adds over 80 unique enchantments to your server and more!
https://modrinth.com/plugin/crazyenchantments
MIT License
154 stars 115 forks source link

Add overrides for CE Books #836

Closed lennardjamie5 closed 4 months ago

lennardjamie5 commented 4 months ago

Overrides set in config.yml allowing server admins to set override values for the success and destroy chances for a CE Book. If set (default is existing functionality) then any calculated value is ignored and this value is used.

ryderbelserion commented 4 months ago

You have to set up your Signing Key so all commits are signed before merging. Can't merge it otherwise...

lennardjamie5 commented 4 months ago

Apologies,

Signed commits above

ryderbelserion commented 4 months ago

If it works, it works

TrueDarkLord commented 4 months ago

Can you rebase the branch so it's in line with the current main branch? It looks like it's 36 commits behind. Once done I will be able to version bump it and merge it.

A suggestion for the future: Create a separate branch for changes. This will make it easier to keep track of the changes and allow you to work on multiple different changes simultaneously.