Add support for Android 13 Themed icons

Crazy-Marvin / Morse

Translator for converting text into morse code and vice-versa

https://crazymarvin.com/morse/

Apache License 2.0

159 stars 31 forks source link

Add support for Android 13 Themed icons #117

Closed snaik20 closed 2 years ago

snaik20 commented 2 years ago

Added the monochrome icon drawable to ic_launcher.xml and ic_launcher_round.xml
Tested with different colors.
Resource used from https://github.com/Crazy-Marvin/Morse/issues/115#issue-1377169578

Screenshots:	Before	After

CrazyMarvin commented 2 years ago

Thank you very much for your help, @snaik20! 😘

snaik20 commented 2 years ago

Hi @CrazyMarvin,

There are some lint errors in the workflow https://github.com/Crazy-Marvin/Morse/actions/runs/3164516228/jobs/5153419906. Are these expected? I'm going to resolve some of them which have a straightforward fix.

CrazyMarvin commented 2 years ago

Hi @CrazyMarvin,

There are some lint errors in the workflow https://github.com/Crazy-Marvin/Morse/actions/runs/3164516228/jobs/5153419906. Are these expected? I'm going to resolve some of them which have a straightforward fix.

That would be great, @snaik20. If the GitHub Actions might be setup better let me know too please. I did not think much about it when I enabled it.

snaik20 commented 2 years ago

Hi @CrazyMarvin, There are some lint errors in the workflow https://github.com/Crazy-Marvin/Morse/actions/runs/3164516228/jobs/5153419906. Are these expected? I'm going to resolve some of them which have a straightforward fix.

That would be great, @snaik20. If the GitHub Actions might be setup better let me know too please. I did not think much about it when I enabled it.

Yes, they are lint warnings. Let's update the Github actions to NOT report warning are errors. Warning can be gradually fixed throughout the app. Let me know if you need help in updating the rules.

CrazyMarvin commented 2 years ago

Hi @CrazyMarvin, There are some lint errors in the workflow https://github.com/Crazy-Marvin/Morse/actions/runs/3164516228/jobs/5153419906. Are these expected? I'm going to resolve some of them which have a straightforward fix.

That would be great, @snaik20. If the GitHub Actions might be setup better let me know too please. I did not think much about it when I enabled it.

Yes, they are lint warnings. Let's update the Github actions to NOT report warning are errors. Warning can be gradually fixed throughout the app. Let me know if you need help in updating the rules.

Yes, please update the rules. 👍

snaik20 commented 2 years ago

Sure. I will fix the error reports first. After that, I will look into the rules.