search

Crazy-Marvin / Morse

Translator for converting text into morse code and vice-versa
https://crazymarvin.com/morse/
Apache License 2.0
140 stars 30 forks source link

Support punctuations #95

Open KrasnayaPloshchad opened 2 years ago

KrasnayaPloshchad commented 2 years ago

If this app could be able to convert a punctuation to morse code or vice versa, this app can present not only a simple phrase like SOS or Hello World but also a complete sentence.

CrazyMarvin commented 2 years ago

This would be a great improvement.
@FahadSaleem is working on refactoring the code and maybe he can directly implement support for punctuations.

CrazyMarvin commented 9 months ago

I suppose the punctuations on https://morsecode.world/international/morse.html would be a good start.

CrazyMarvin commented 8 months ago

Are you interested to help with this too, @fejd? 😅

You have done so much so it's fine if you say no.

fejd commented 8 months ago

Sure, I could take a look. Is the code refactoring still in progress? I was thinking of breaking things out of the main activity and perhaps convert some of that functionality to Kotlin in the process. :)

If I understand the feature request correctly, there should be a mapping of punctuations from the "Punctuation Mark" table in https://morsecode.world/international/morse.html to dots/dahs.

I noticed on https://morsecode.world/international/timing.html that the timing is different depending on the type of space between characters and words. I should probably revisit the sound playback and adapt the pause between sounds based on that. Also, maybe it's useful to share the "playback algorithm" between audio, camera flash and "screen flash"?

CrazyMarvin commented 8 months ago

The refactoring did not start yet unfortunately. So feel welcome to start with it. 😅

Yes, you understood this correctly. 👍

There is another issue about the timing: https://github.com/Crazy-Marvin/Morse/issues/36. This is a bit more complex but it would be awesome if you could tackle it though.

Noitarud commented 5 months ago

I only have: morse-sec001a4

CrazyMarvin commented 5 months ago

Do you have time for this or are you busy, @fejd?

fejd commented 5 months ago

@CrazyMarvin Sorry, I'll be a bit busy for the next 3-4 months.

CrazyMarvin commented 5 months ago

@CrazyMarvin Sorry, I'll be a bit busy for the next 3-4 months.

Alright, thanks for the info. 👍