search

Crazy-Marvin / VacationDays

Know when you are free.
https://crazymarvin.com/vacation-days/
Apache License 2.0
37 stars 9 forks source link

No Daycount validation #115

Closed amarradi closed 11 months ago

amarradi commented 1 year ago

Screenshot_20221009-211038~2.png

I can currently allocate more days than I have available.

CrazyMarvin commented 1 year ago

I am not sure how Vacation Days should handle this behaviour. 🤔

It is possible to schedule more vacation days than are available. These will then be deducted in the next year. It is not a standard, but when an employee needs more vacation days most employers allow this.

CrazyMarvin commented 11 months ago

We will keep the behaviour as is.

amarradi commented 11 months ago

Maybe an if condition would be good, comparing whether the selected number is less than or equal to the vacation days. And then show an info box saying that the maximum number has been reached. If you do not check the vacation days entered somehow, you can also remove the vacation days entry.

amarradi commented 11 months ago

I'll try to implement it and give you a pull requests

CrazyMarvin commented 11 months ago

Maybe an if condition would be good, comparing whether the selected number is less than or equal to the vacation days. And then show an info box saying that the maximum number has been reached. If you do not check the vacation days entered somehow, you can also remove the vacation days entry.

I would be fine with an info box. 👍 But it should be possible to go over the quota and see something like -4.